Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): better payload definitions #409

Closed
wants to merge 18 commits into from

Conversation

octokitbot
Copy link
Collaborator

@octokitbot octokitbot commented Jan 23, 2021

A new release of @octokit/webhooks was just released 👋🤖

This pull request updates the TypeScript definitions derived from @octokit/webhooks. I can't tell if the changes are fixes, features or breaking, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.


View rendered README.md

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 23, 2021
G-Rath
G-Rath previously approved these changes Jan 24, 2021
gr2m
gr2m previously approved these changes Jan 24, 2021
@github-actions github-actions bot dismissed stale reviews from gr2m and G-Rath via d2a5839 January 24, 2021 22:42
@wolfy1339
Copy link
Member

Should this be merged in the meantime until the new types from @octokit/webhooks-definitions are merged in

@G-Rath
Copy link
Member

G-Rath commented Jan 30, 2021

@wolfy1339 there shouldn't be harm in doing so, just needs the conflicts resolved 🤷 (both the git ones and the human ones of supporting the new structure - iirc it should just continue to work fine because the payloads haven't changed and they're where the types are generated from until #406 is landed)

wolfy1339
wolfy1339 previously approved these changes Jan 30, 2021
@wolfy1339 wolfy1339 changed the title 🚧 🤖📯 Webhooks changed feat(typescript): update types for webhook events from @octokit/webhook-definitions Jan 30, 2021
@wolfy1339 wolfy1339 changed the title feat(typescript): update types for webhook events from @octokit/webhook-definitions feat(typescript): better payload definitions Jan 30, 2021
wolfy1339
wolfy1339 previously approved these changes Jan 30, 2021
wolfy1339
wolfy1339 previously approved these changes Jan 30, 2021
@wolfy1339
Copy link
Member

@gr2m It seems there's a problem with the tests. They don't seem to be running at all

@G-Rath
Copy link
Member

G-Rath commented Jan 30, 2021

@wolfy1339 weirdly I just noticed that my CI checks don't seem to have ever run for the PRs created by the action on my function repo (i.e G-Rath/compare-gh-webhook-to-schema-function#35) - I've got no idea what difference there is that means the CI rules I've got setup are not being met.

Might be the two are related?

@gr2m
Copy link
Contributor

gr2m commented Jan 30, 2021

Hmm I don't know why the tests are not running, very odd! We do use a personal access token to create / update this pull request, so it should not be caused by the limitations that a github action cannot trigger another github action (when using secrets.GITHUB_TOKEN). I'll ask support

Update: fixed by pushing an empty commit (7eaa7af), must have been a temporary hiccup?

oscard0m
oscard0m previously approved these changes Feb 2, 2021
@wolfy1339
Copy link
Member

Superseded by #406

@wolfy1339 wolfy1339 closed this Feb 2, 2021
@wolfy1339 wolfy1339 deleted the update-octokit-webhooks branch February 2, 2021 18:13
@wolfy1339 wolfy1339 restored the update-octokit-webhooks branch February 2, 2021 22:26
@wolfy1339 wolfy1339 deleted the update-octokit-webhooks branch February 2, 2021 22:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants