Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

middlewares: define inventory for http.RoundTripper #1

Open
3 tasks
kamilsk opened this issue Jan 10, 2021 · 0 comments
Open
3 tasks

middlewares: define inventory for http.RoundTripper #1

kamilsk opened this issue Jan 10, 2021 · 0 comments
Assignees
@kamilsk
Labels
difficulty: medium Issue has medium complexity. kind: feature New feature request. scope: code Issue related to source code. scope: eqpt Issue related to auxiliary code, e.g. CI config, Makefiles, etc. scope: test Issue related to tests.

Comments

@kamilsk
Copy link
Member

kamilsk commented Jan 10, 2021 •
edited
Loading

Motivation: make core functionality extendable and improve the developer experience.

Steps:

  • define type
type Middleware func (http.RoundTripper) http.RoundTripper
  • prefixed RoundTripper
func RoundTripper(prefix) Middleware
  • timeout RoundTripper
func RoundTripperMiddleware(http.RoundTripper) http.RoundTripper

inject X-Deadline header

Inspiration:

It allows unlocking kamilsk/tracer/issues/9.
@kamilsk kamilsk added the help wanted Extra attention is needed. label Jan 10, 2021
@kamilsk kamilsk self-assigned this Jan 10, 2021
@kamilsk kamilsk mentioned this issue Jan 10, 2021
Closed
3 tasks
kamilsk added a commit that referenced this issue Jan 12, 2021
@kamilsk
issue #1 and #2: define base types
e85c8da
@kamilsk kamilsk added kind: feature New feature request. and removed help wanted Extra attention is needed. labels May 11, 2022
@kamilsk kamilsk added difficulty: medium Issue has medium complexity. scope: code Issue related to source code. scope: eqpt Issue related to auxiliary code, e.g. CI config, Makefiles, etc. scope: test Issue related to tests. labels May 28, 2022
@kamilsk kamilsk changed the title RoundTripper middlewares middlewares: define for RoundTripper May 28, 2022
@kamilsk kamilsk changed the title middlewares: define for RoundTripper middlewares: define inventory for RoundTripper May 28, 2022
@kamilsk kamilsk changed the title middlewares: define inventory for RoundTripper middlewares: define inventory for http.RoundTripper May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilsk kamilsk

Labels
difficulty: medium Issue has medium complexity. kind: feature New feature request. scope: code Issue related to source code. scope: eqpt Issue related to auxiliary code, e.g. CI config, Makefiles, etc. scope: test Issue related to tests.
Projects
🏗 Platform
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kamilsk