Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dlr.proto to proto-generate command #14

Closed
Sddilora opened this issue Apr 30, 2024 · 0 comments · Fixed by #30
Closed

Add dlr.proto to proto-generate command #14

Sddilora opened this issue Apr 30, 2024 · 0 comments · Fixed by #30
Assignees
Labels
Be development Issues or tasks currently in active development low priority Minor issues, can be addressed later

Comments

@Sddilora
Copy link
Member

Explanation:
The proto-generate command in the Makefile is responsible for generating Go code from protobuf files (*.proto). Currently, it includes several protobuf files for code generation, but it's missing dlr.proto.

Action:
Update the proto-generate command in the Makefile to include pkg/proto/model/dlr.proto as follows:

proto-generate: ## Protobuf Generate
	protoc -I=pkg/proto/model \
		--go_out=../../../ \
		--go-grpc_out=../../../ \
		pkg/proto/model/error.proto \
		pkg/proto/model/logging.proto \
		pkg/proto/model/authentication.proto \
		pkg/proto/model/authorization.proto \
		pkg/proto/model/user.proto \
		pkg/proto/model/dlr.proto \   # Added dlr.proto here
		--experimental_allow_proto3_optional
@Sddilora Sddilora changed the title Add dlr.proto to proto-generate command in Makefile Add dlr.proto to proto-generate command Apr 30, 2024
@Sddilora Sddilora added low priority Minor issues, can be addressed later development Issues or tasks currently in active development labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Be development Issues or tasks currently in active development low priority Minor issues, can be addressed later
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants