-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date's are incorrect. Did Arvelie change? #1
Comments
I pulled down oscean and found |
No, wait. Yikes. I'm sorry for all the notifications, but I don't trust that C file. If we look at the XXIIVV tracker page, we never see If I were to guess, the first Arvelie was 1-based, but it's now 0-based. EDIT:
|
hi @neauoire, did you end up updating the date to be 0 based? |
A yes, as of this year Arvelie is now zero based. I haven't updated the js version, it's possible that the examples on XXIIVV are incorrect now. I'll double check :) |
In
lib.js
it seems that you set the day to+01
if it's December 31st, and+02
is used on February 29th. I'm pretty sure this is incorrect, but I am not sure what is correct.On the XXIIVV page for arvelie, it gives two examples for these times.
14C01 2009-01-29
for February 29th as a leap day, and03+00 2010-12-31
to show the what end-of-year would look like when it's not a leap year.I found arvelie a bit confusing until I just tried to explain this (thanks rubber duck debugging!) and I believe
Z+00
is the regular, non leap year month-day, andZ+01
would be the leap-year month-day. 365 / 14 is 26 with 1 remainder, so a regular year getsZ00
on the 364th day, andZ+00
to deal with that one extra.Z+01
adds that extra day which is kind of beautiful.Sorry if I explained this too much, I'm making a CLI arvelie, too, and this helped me figure it out.
The text was updated successfully, but these errors were encountered: