Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date's are incorrect. Did Arvelie change? #1

Open
gennyble opened this issue Apr 8, 2021 · 4 comments
Open

Date's are incorrect. Did Arvelie change? #1

gennyble opened this issue Apr 8, 2021 · 4 comments

Comments

@gennyble
Copy link

gennyble commented Apr 8, 2021

In lib.js it seems that you set the day to +01 if it's December 31st, and +02 is used on February 29th. I'm pretty sure this is incorrect, but I am not sure what is correct.
On the XXIIVV page for arvelie, it gives two examples for these times. 14C01 2009-01-29 for February 29th as a leap day, and 03+00 2010-12-31 to show the what end-of-year would look like when it's not a leap year.
I found arvelie a bit confusing until I just tried to explain this (thanks rubber duck debugging!) and I believe Z+00 is the regular, non leap year month-day, and Z+01 would be the leap-year month-day. 365 / 14 is 26 with 1 remainder, so a regular year gets Z00 on the 364th day, and Z+00 to deal with that one extra. Z+01 adds that extra day which is kind of beautiful.

Sorry if I explained this too much, I'm making a CLI arvelie, too, and this helped me figure it out.

@gennyble
Copy link
Author

gennyble commented Apr 8, 2021

I pulled down oscean and found arvelie.c on May 17th, 2020. It seems that the examples on the XXIIVV arvelie page are wrong, because the two do not match. Closing, sorry.

@gennyble gennyble closed this as completed Apr 8, 2021
@gennyble
Copy link
Author

gennyble commented Apr 8, 2021

No, wait. Yikes. I'm sorry for all the notifications, but I don't trust that C file.

If we look at the XXIIVV tracker page, we never see 14 in the day position. Further, with arvelie.c, we get A01 on Jan 1st of a year, but there are a significant number of A00's on the tracker page. This leads me to believe that my first comment is correct, and I'll reopen the issue. I should have thought about it more before closing, clearly.

If I were to guess, the first Arvelie was 1-based, but it's now 0-based.

EDIT:
I might be a little blind. It's funny because I'm wearing glasses. Arvelie's page says this:

The arvelie date 13A05, is equivalent to January 6th of the 14th year.

@gennyble gennyble reopened this Apr 8, 2021
@gennyble gennyble changed the title Date incorrect near year end Date's are incorrect. Did Arvelie change? Apr 8, 2021
@octref
Copy link
Owner

octref commented Apr 9, 2021

XXIIVV/oscean#64 (comment)

hi @neauoire, did you end up updating the date to be 0 based?

@neauoire
Copy link

neauoire commented Apr 9, 2021

A yes, as of this year Arvelie is now zero based. I haven't updated the js version, it's possible that the examples on XXIIVV are incorrect now. I'll double check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants