Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capabilities Vocabulary loaded in all EDM Models looks out of date / incomplete #51

Closed
ghost opened this issue Jan 14, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 14, 2015

Description

There is a version of the OData.OData.Capabilities.V1 vocabulary hosted on Oasis which seems mostly complete: https://tools.oasis-open.org/version-control/browse/wsvn/odata/trunk/spec/vocabularies/Org.OData.Capabilities.V1.xml

The version used internally seems to be much smaller and incomplete.
https://github.com/OData/odata.net/blob/master/src/Edm/Microsoft/OData/Edm/Vocabularies/CapabilitiesVocabularies.xml#L7

Is there a standard capabilities vocabulary hosted somewhere? Which version should be loaded by EDM implicitly? In the status quo, the latter vocabulary is loaded, but this doesn't seem correct.

Minimal repro steps

  1. Instantiate a EDMModel
  2. Attempt to add InsertRestriction annotation to the model

Expected result

InsertRestriction can be added without loading additional vocabularies since capabilities are already implicitly referenced in all EDMModels

Actual result

Must explicitly load a copy of the capabilities vocabulary that is more complete. Preferably one similar in completeness to https://tools.oasis-open.org/version-control/browse/wsvn/odata/trunk/spec/vocabularies/Org.OData.Capabilities.V1.xml

@dingeins
Copy link
Contributor

Capabilities vocabulary isn't completely supported because not all the elements and attributes for defining annotations is supported in the EdmLib.

xuzhg added a commit to xuzhg/odata.net that referenced this issue Jun 9, 2015
xuzhg added a commit to xuzhg/odata.net that referenced this issue Jun 12, 2015
xuzhg added a commit to xuzhg/odata.net that referenced this issue Jun 12, 2015
@mikepizzo
Copy link
Member

It appears from the conversation thread that this has been addressed. If not, please feel free to re-open and add any missing capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants