Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the entire processor pipeline work with streams #4

Closed
maanlamp opened this issue Jan 9, 2019 · 1 comment
Closed

Make the entire processor pipeline work with streams #4

maanlamp opened this issue Jan 9, 2019 · 1 comment
Assignees
Labels
feature New feature or request will break Will break existing code

Comments

@maanlamp
Copy link
Member

maanlamp commented Jan 9, 2019

For testing, we're processing small files. When the language will be used in bigger projects, it will not scale if it has to load and save everything into memory. Streams were introduced exactly for this use case, so we should use them.

@maanlamp maanlamp added feature New feature or request will break Will break existing code labels Jan 9, 2019
@maanlamp maanlamp self-assigned this Jan 9, 2019
@maanlamp maanlamp mentioned this issue Jan 11, 2019
@maanlamp
Copy link
Member Author

maanlamp commented Jun 6, 2019

Lexical analysis of streams turns out to be more trouble than it's worth (sometimes errors at valid code, sometimes doesn't error at invalid code), so we're postponing this for when it is actually needed. Maybe reopen this issue then. To allow for the change at any time, we are going to use a new generator function pattern to export tokens from the lexer.

@maanlamp maanlamp closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request will break Will break existing code
Projects
None yet
Development

No branches or pull requests

1 participant