Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: use program.recoverFileSystem instead of doing it manually #113

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

avivash
Copy link
Member

@avivash avivash commented Jan 12, 2023

Description

Moving the FileSystem recovery functionality into webnative. Devs can now call the fileSystem.recover method directly from the program. It is important to note the newUsername and oldUsername that are passed in are the hashed versions, as webnative doesn't yet have a notion of the unhashed versions. (That will be completed in oddsdk/ts-odd#385)

const { success } = await $sessionStore.program.fileSystem.recover({
  newUsername,
  oldUsername,
  readKey
})

Note: I'll add this same functionality to WAT-react once these PRs have been merged

Link to issue

oddsdk/ts-odd#427

Type of change

  • Refactor (non-breaking change that updates existing functionality)

Screenshots/Screencaps

https://www.loom.com/share/b2ecfe8fa8a04f7e96dab76d8dc749a6

Sibling PR

oddsdk/ts-odd#461

@avivash avivash self-assigned this Jan 12, 2023
@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webnative-app-template ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 11:02PM (UTC)

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ad0707
Status: ✅  Deploy successful!
Preview URL: https://02f63a63.webnative-template.pages.dev
Branch Preview URL: https://avivash-use-webnative-fs-rec.webnative-template.pages.dev

View logs

Copy link
Member

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉 💯

@avivash avivash merged commit 88725d3 into main Feb 3, 2023
@avivash avivash deleted the avivash/use-webnative-fs-recovery branch February 3, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants