Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username scheme and hashing support #385

Open
walkah opened this issue Jun 29, 2022 · 4 comments
Open

Add username scheme and hashing support #385

walkah opened this issue Jun 29, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@walkah
Copy link
Contributor

walkah commented Jun 29, 2022

For AOL apps where email may be optional, provide a function to allow implementations to provide an identity function (auto generated username).

@walkah walkah changed the title Add identify function for cases where username and/or email not available (AOL) Add identify function Jun 29, 2022
@bgins bgins changed the title Add identify function Add username serialization function Jul 22, 2022
@bgins
Copy link
Member

bgins commented Jul 22, 2022

Renamed this issue because we will likely end up with a serialized, internal representation of the username. We will still want the human readable username for user interactions.

@bgins bgins changed the title Add username serialization function Add username serialization functions Jul 25, 2022
@expede
Copy link
Member

expede commented Jul 25, 2022

@bgins & @expede to discuss base64 vs hashing for linking

@icidasset icidasset added the enhancement New feature or request label Aug 8, 2022
@bgins bgins changed the title Add username serialization functions Add username scheme and hashing support Aug 11, 2022
@avivash
Copy link
Member

avivash commented Jan 11, 2023

@bgins would it make sense to do this as part of the fs recovery work since they're both fairly tied together? I'm assuming "Add username scheme and hashing support" refers to the same functionality we've already implemented in WAT?

@bgins
Copy link
Member

bgins commented Jan 11, 2023

@avivash yep, the work is similar, but we would want to generalize the interface to give developers the option to hash or not. The main reason for that is backwards compatibility with existing usernames, but going forward some developers may want a plain name so their users have a nice domain name on the HTTP gateway like https://yeti.files.fission.name/.

The other consideration is whether or not to support username schemes. The idea with schemes is the developer could define a templated username that includes the app's domain name that would create a namespace for users. We could potentially skip this part for now. There are some great benefits to the hashing part on its own.

My intuition is that filesystem recovery and hashing support will be independent features in Webnative. If you're up for both, I think adding hashing support would be great! Let's maybe chat about it, and I can share some additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants