-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avivash/File System Recovery Shorthand Method #461
Conversation
ahh, i'll update the changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments, looks great otherwise! 🥳
No event emitter yet in Webnative, but it's on the short-term todo list! Also, bit confused about the example shown here, this should work with regular usernames too right? |
Nice!
Ahh yes good point! I should remove the term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! ✨
Left a few comments. One thing we want to consider how developers will create a recovery kit to use this shorthand function. More on that in the comments.
e39fb74
to
4b25f37
Compare
Summary
This PR fixes/implements the following bugs/features
recoverFileSystem
shorthandMoving the FileSystem recovery functionality into
webnative
. Devs can now call therecoverFileSystem
shorthand method directly from theprogram
. It is important to note thenewUsername
andoldUsername
that are passed in are the hashed versions, aswebnative
doesn't yet have a notion of the unhashed versions. (That will be completed in #385)Note: I'm not sure if we currently have the infrastructure in the codebase for this, but it would be cool if we could emit events at various parts of the recovery flow to update the message on the client 🤔Answered by Steven!Test plan (required)
Load WAT using this
webnative
branch and go through the recovery flow. It should work the same as it did before.https://www.loom.com/share/b2ecfe8fa8a04f7e96dab76d8dc749a6
Closing issues
Closes #427
After Merge
Sibling PR
oddsdk/odd-app-template#113