Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing for Positional and Named Arguments in Procedure Calls #2597

Merged
merged 28 commits into from Jun 23, 2023
Merged

Allowing for Positional and Named Arguments in Procedure Calls #2597

merged 28 commits into from Jun 23, 2023

Conversation

gingerBill
Copy link
Member

@gingerBill gingerBill commented Jun 20, 2023 •
edited

Allows for the following:

foo(134, "hellope", x=true, y=4.5)

Position arguments must always come before named arguments.

@z64
Copy link
Contributor

z64 commented Jun 20, 2023

This is awesome, it was one of the few things I was missing in Odin compared to other languages I work with. Thank you!

@gingerBill gingerBill changed the title Allowing for Positional and Named Arguments in Procedure Calls WIP: Allowing for Positional and Named Arguments in Procedure Calls Jun 20, 2023
@gingerBill gingerBill added frontend needs-validation Reviewers need to validate that everything is in working order labels Jun 21, 2023
@gingerBill gingerBill marked this pull request as ready for review June 21, 2023 14:17
@gingerBill gingerBill changed the title WIP: Allowing for Positional and Named Arguments in Procedure Calls Allowing for Positional and Named Arguments in Procedure Calls Jun 21, 2023
@rxi
Copy link

rxi commented Jun 22, 2023

Click merge

@gingerBill gingerBill merged commit 9841b11 into master Jun 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelimion Kelimion Awaiting requested review from Kelimion

@graphitemaster graphitemaster Awaiting requested review from graphitemaster

@oskarnp oskarnp Awaiting requested review from oskarnp

@colrdavidson colrdavidson Awaiting requested review from colrdavidson

@awwdev awwdev Awaiting requested review from awwdev

Assignees
No one assigned
Labels
compiler-development enhancement feature idea frontend implementation llvm-backend needs-validation Reviewers need to validate that everything is in working order
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gingerBill @z64 @rxi