Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better python installation #10

Open
adler-j opened this issue Nov 29, 2015 · 4 comments
Open

A better python installation #10

adler-j opened this issue Nov 29, 2015 · 4 comments

Comments

@adler-j
Copy link
Member

adler-j commented Nov 29, 2015

The current install script assumes the user wants to install for the python, and also happens to have a somewhat restrictive licence. When discussing this isuse in STIR with Kris he pointed out a better script, we should swap to that. Togeather with fixing issue #9, this would greatly improve the install process.

@kohr-h
Copy link
Member

kohr-h commented Dec 8, 2015

Part of the same issue, but going into a slightly different direction: We should have a setup.py for this package and should also implement a wheel build. That's the way to go in my opinion, hopefully it can be configured well enough so we can cover a couple of setups. Before I don't see a good chance to run CUDA tests on the CI machine.

@adler-j
Copy link
Member Author

adler-j commented Dec 8, 2015

I see the point of setup.py, but why cant you simply cmake --FLAGS YOU NEED TO SET HARDCODED make for the CI?

@kohr-h
Copy link
Member

kohr-h commented Dec 8, 2015

Oh I don't mean for CI, but for distribution later. Of course, I can just set the flags as I need them for the CI machine.

@kohr-h
Copy link
Member

kohr-h commented Dec 8, 2015

I made some simple changes in the code, now it installs smoothly into a Py3 environment, too. And Jenkins can also build it now. You're going to get angry mails when you break something :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants