Skip to content

Commit

Permalink
[FIX] base: return super().unlink() for ir.ui.view.unlink()
Browse files Browse the repository at this point in the history
Commit bca2926 introduced a fix for
ir.ui.view unlinks during uninstall but forgot to return the result of
the super() call to unlink which broke behaviour downstream.

This commit restores the proper behavior of returning the result of the
call to super.

Closes odoo#52364

closes odoo#52401

X-original-commit: c526410
Signed-off-by: Adrian Torres (adt) <adt@odoo.com>
  • Loading branch information
Adrian Torres committed Jun 4, 2020
1 parent 711d1a8 commit a3d91cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion odoo/addons/base/models/ir_ui_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ def unlink(self):
# if in uninstall mode and has children views, emulate an ondelete cascade
if self.env.context.get('_force_unlink', False) and self.inherit_children_ids:
self.inherit_children_ids.unlink()
super(View, self).unlink()
return super(View, self).unlink()

@api.returns('self', lambda value: value.id)
def copy(self, default=None):
Expand Down

0 comments on commit a3d91cc

Please sign in to comment.