[IMP] sales: 100 percent down #9664
Conversation
pabr-odoo
force-pushed
the
17.0-crm-100-percent-down-payment-pabr
branch
2 times, most recently
from
da166bc
to
8c8cd4c
Compare
|
Hey @StraubCreative, tagging you on this new section on using 100% down that you mentioned before. Thanks |
StraubCreative
requested review from
ksc-odoo
and removed request for
StraubCreative
There was a problem hiding this comment.
Hey @pabr-odoo -- just finished my Review of this PR. Great work, man. 👍 Just have a handful of comments/feedbacks/suggestions that require your attention -- but I am approving now because I don't anticipate you having any issues. However, if you have any questions about any of them (or how to implement them), don't hesitate to reach out.
Once you make the required adjustments/modifications, feel free to tag this for Tech Review. Thanks! 👍
|
Related Concern: https://www.odoo.com/odoo/project.task/3928233?cids=3 More Info: The customer is using the down payment invoice to process full down payments for foreign currencies. An Exchange difference is appearing creating a receivable of .01 EUR. The extra .01 on the receivable account is due to exchange rate rounding on the final invoice INV/2023/0117. Each sales account line is rounded from USD to Euro and then rounded off. In this case, there are about 7 lines and after rounding all 7, a small bit of value is lost. The credits to sales/income account 601100 add to 6980.82 (see link above) but the amount debited to the deposit account 324000 is 6980.83. Please consider how the use of foreign currencies may affect the this process. |
pabr-odoo
force-pushed
the
17.0-crm-100-percent-down-payment-pabr
branch
2 times, most recently
from
9129d2f
to
17c88bc
Compare
|
Hey @samueljlieber this additional section is ready for tech review once you get the chance. Thanks! |
There was a problem hiding this comment.
Hi @pabr-odoo! Nice work on this Sales PR on 100% down payments. Your changes are looking good to me! I just have a couple quick fixes, nitpicks, and suggestions for you. Please tag me once more for a final look once these have been addressed, thank you for your work!
|
Hey @samueljlieber thanks so much for your review. I looked over and committed your suggestions. Please give it a final look when you get the chance and let me know if you have any other changes. Thanks! |
pabr-odoo
force-pushed
the
17.0-crm-100-percent-down-payment-pabr
branch
from
2b81f49
to
671729b
Compare
There was a problem hiding this comment.
Hi @pabr-odoo, thank you for implementing my suggestions! Changes look good 👍 Approving with one more quick fix. Please make this fix before merging :)
..
@robodoo delegate=pabr-odoo
pabr-odoo
force-pushed
the
17.0-crm-100-percent-down-payment-pabr
branch
from
671729b
to
a3e52d1
Compare
|
@robodoo r+ |
Task 3971833
Added a new section to the Down payments doc explaining the process of using a 100% down payment option when invoicing.
Related Task 3928233