Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] l10n: PoC doc restructure for CO #3167

Closed

Conversation

StraubCreative
Copy link
Contributor

@StraubCreative StraubCreative commented Dec 8, 2022

Cherry pick of #2659, now pointing to the correct base branch.

@StraubCreative and @samueljlieber found the latam l10n docs could use an update/cleanup to break apart the single long-form article for each l10n module.

This PR was created as a proof of concept to improve the structure of latam l10n docs so they are more consumable and follow a similar flow to the rest of the documentation. The proposed document structure is for Colombia only in this PR, although this structure applies to all latam l10n countries.

The details of the proposed document structure can be found here, the structure is summarized below:

localizations
└── colombia
└── colombia.rst
..........├── configuration
..........├── reports
..........├── workflows
..........├── configuration.rst
..........├── reports.rst
..........└── workflows.rst

colombia.rst is the main l10n doc providing an introduction, video tutorials, scope, and glossary of terms.
|_ configuration.rst outlines the steps to install the localization module and the basic configuration setup.
|_ workflows.rst outlines the main workflows of the module, common problems/errors, and more advanced workflows.
|_ reports.rst outlines the financial reporting process of the module.

Each nested RST doc contains it's own media folder with the same name.

The goal is to build a working model, and then replicate + keep this consistent structure throughout latam l1on docs.

EDIT: summarized doc structure, removed configuration doc/folder, merged content into colombia.rst per the ideal User Doc Structure guidelines.

@robodoo
Copy link
Collaborator

robodoo commented Dec 8, 2022

@StraubCreative
Copy link
Contributor Author

Initial commit: 93428cc

  • removed colombia_ES.rst
  • reorganized images to properly named folders instead of general colombia folder
  • small content updates on top of cherry-picked commit 497206d

@StraubCreative StraubCreative force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from 93428cc to f6c29c3 Compare December 8, 2022 23:20
@StraubCreative
Copy link
Contributor Author

Updates in f6c29c3:

  • addressed failing CI checks
    • removed deleted file path from localizations.rst
    • fixed image file paths inconfiguration.rst

PR passes CI Checks now— free to continue with layout rebuild and content updates 🚀

cc: @samueljlieber

@StraubCreative
Copy link
Contributor Author

@odoo/accounting-doc-review this is still a work in progress but worth bringing up on your radar.
Will ping you when it's ready for review.
Thank you 🙏

cc: @jcs-odoo

@chiaraprattico
Copy link
Contributor

Hi guys, I started my review, but I guess this is not finished, so I'll wait for you to confirm it once it's done. :)

Thanks!

@samueljlieber samueljlieber force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from f6c29c3 to 4265818 Compare December 28, 2022 16:08
@samueljlieber
Copy link
Contributor

samueljlieber commented Dec 28, 2022

Hi @StraubCreative, thank you for getting this PR up to date!

Updates in 4265818:

  • Added content to the reports.rst doc
  • Removed the Glossary and Scope sections from colombia.rst
  • Enabled the table of contents in colombia.rst to show links to Configuration, Workflows, & Reports

@samueljlieber samueljlieber force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch 2 times, most recently from 56e0af8 to 8c56efd Compare December 28, 2022 19:42
@samueljlieber
Copy link
Contributor

56e0af8 to remove 16.0 specific images ➡️ 8c56efd to add 14.0 specific images.

Hey there @StraubCreative, @vbe-odoo, & @ren-odoo 👋 can you please review the entire CO L10n content and add suggestions as necessary?

Thank you everyone for your continued hard work on this!

@ren-odoo
Copy link
Contributor

Hi @samueljlieber

I left some minor suggestions, but general structure considering the new approach, looks good :)

There some images that are outdated, mainly because this localization has have several changes since the first documentation was created, there are well important new workflows and use cases that we want to add to the website documentation. Should we include this improvements and additions in this PR or should we handle this on a diferent PR once the new general structure is merged?

cc. @StraubCreative @vbe-odoo @fvz-odoo @and-Odoo

Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello :) just a few small comments after having scanned the pr, not in detail.

I wonder if splitting the page into several smaller ones works well here. Maybe it can, but it feels wrong as it is now...

The "Colombia" category page is empty and would only have a link to a youtube video. If there was some useful content redirecting to the subpages, then why not, but then it would probably become redundant with "workflow" and "reports".

Well, have a good weekend and... see you next year 😁

@samueljlieber samueljlieber force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from 8c56efd to f22a6e5 Compare December 30, 2022 21:59
@samueljlieber
Copy link
Contributor

samueljlieber commented Dec 30, 2022

Thank you @jcs-odoo and @ren-odoo for the suggestions 🙂

Updates in f22a6e5:

  • Reworded the video tutorials description
  • Moved the module list to configuration.rst and removed version specific copy and image
  • Removed the guilabel from reports.rst
  • Added an Introduction description

I added the introduction description as a possible solution to @jcs-odoo comment, let me know what you all think.

@ren-odoo regarding your comment about adding new workflows and use cases in this PR, I think it would be best to handle this in a different PR once these structural changes are merged - wdyt @StraubCreative?

See you next year 🥳

@samueljlieber samueljlieber force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from f22a6e5 to adcafb4 Compare March 8, 2023 17:09
@samueljlieber
Copy link
Contributor

Updates in adcafb4:

  • fixed merge conflicts due to new Fiscal Localization structure

@jcs-odoo jcs-odoo requested review from a team and removed request for a team March 8, 2023 17:13
@samueljlieber samueljlieber force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from adcafb4 to 1849105 Compare April 11, 2023 20:55
@samueljlieber
Copy link
Contributor

@StraubCreative
Copy link
Contributor Author

Quick touchups on b478f96. Checks pass ✅

@jcs-odoo and @odoo/localizations-doc-review team,
At long last this is ready for your review 🙏

The purpose of this PR was to break apart the CO l10n documentation into individual RST files so the content was more digestible in steps for users. After working with @ren-odoo 's team, this was the way we thought it would best make sense right now, and for developing further on future PRs.

If approved, we'd expand on these docs more for CO with more in-depth written instruction, and would duplicate the PoC structure to other LATAM l10n documentation (PE, AR, EC, etc.), as the opportunity arises.

Thanks in advance for your review and thank you @samueljlieber and Team @ren-odoo for your help!

Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks again for all the great work!

I still think all the content could fit on a single page if there is a nice intro that introduces the various sections of the page.

If you have a look at the structure of all three pages, they all have a single h2 heading, which defeats the purpose of having one at all somehow. Also, the reports page is still ultra short. Combined into a single page, these headings become sections that look well organized.

image

I'll force-push this branch in a minute. I kept changes in separate commits so we can easily pick or drop any if needed. :) We'll squash them all into a single commit before merging the PR.

  • 1st commit is the original one (I also rebased the branch since there was a bug with werkzeug on older bases)
  • 2nd commit: some changes and fixes (most are commented in this review normally)
  • 3rd commit: moving everything to a single page, to see how it would look like
  • 4th commit: adding some custom anchors to headings to link them in the intro of the page, as suggested previously in an old comment (although I hoped at the time we could use cards) but it would certainly need to be improved. It's just to give you an example
    image

I agree 100% that longer docs can be split into several ones, but here it still seems a bit overkill, IMO. Also, longer pages could sometimes have less content and go straight to the point, have links to other pages that already describe the same flow (I'm not saying this for this colombian doc, but in general), and have fewer images (for example the Mexican localization)

Anyway, let me know what you think of it. :) Maybe I don't see something.

Cheers!

redirects/14.0.txt Outdated Show resolved Hide resolved
Comment on lines +21 to +26
Modules installation
--------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section won't be useful in more recent versions of the doc since the packages installation has been ultra simplified (and will be described in the fiscal_localizations parent page (cc @chiaraprattico @dade-odoo @toaa-odoo )
image

- Default :ref:`fiscal localization package <fiscal_localizations/packages>`
* - :guilabel:`Colombia E-invoice Integration`
- `l10n_co_edi`
- Carvajal e-invoicing integration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the other modules that can be installed

@jcs-odoo jcs-odoo force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from b478f96 to 1f41de9 Compare June 12, 2023 17:03
@samueljlieber
Copy link
Contributor

Hi @jcs-odoo 👋 thank you for the informative response and commits! I agree with your changes, and I have another PR #4425 that improves the content which I will now update to follow the structure you have implemented on this PR.

I'm happy to squash commits 1, 2, 3 and 4 they look good to me 🙂 please let me know if you would like me to do so!

@jcs-odoo jcs-odoo force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from 1f41de9 to a2a282c Compare June 22, 2023 19:19
@samueljlieber
Copy link
Contributor

Hi @jcs-odoo and @odoo/localizations-doc-review this PR is ready for your final review. I have another PR #4425 waiting on this restructure that will improve the content of the colombia.rst doc. Is there anything I can do to help move this PR along? Thank you 🙂

@jcs-odoo jcs-odoo force-pushed the 14.0-l10n-poc-doc-restructure-for-co-zst branch from a2a282c to a36a5c8 Compare August 11, 2023 09:10
@jcs-odoo
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants