Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] l10n: CO content updates #4425

Closed
wants to merge 1 commit into from
Closed

[IMP] l10n: CO content updates #4425

wants to merge 1 commit into from

Conversation

samueljlieber
Copy link
Contributor

@samueljlieber samueljlieber commented May 13, 2023 •
edited
Loading

This PR improves the content of the CO L10n documentation following the restructure in #3167.

This PR must follow the merge of #3167 and can be forward ported to 15.0 and 16.0

@samueljlieber samueljlieber self-assigned this May 13, 2023
@robodoo
Copy link
Collaborator

robodoo commented May 13, 2023

Pull request status dashboard.

@samueljlieber samueljlieber mentioned this pull request May 13, 2023
Closed
@samueljlieber samueljlieber force-pushed the 14.0-l10n-co-content-updates-sali branch from bd756fc to 0ddaa2b Compare May 17, 2023 18:58
@samueljlieber
Copy link
Contributor Author

Updated this PR in 0ddaa2b to resemble the restructure in #3167. This PR is ready for your review @StraubCreative 🙂

@samueljlieber samueljlieber force-pushed the 14.0-l10n-co-content-updates-sali branch from 0ddaa2b to 7ae2419 Compare June 20, 2023 14:28
@samueljlieber
Copy link
Contributor Author

Updated this PR in 7ae2419 as a second commit to follow the structure JCS implemented in #3167. I will squash this commit after JCS approves the structure on the related PR.

@samueljlieber samueljlieber force-pushed the 14.0-l10n-co-content-updates-sali branch from 7ae2419 to c4f1221 Compare August 11, 2023 18:32
@samueljlieber
Copy link
Contributor Author

Rebased the merge of the l10n_co restructure and squashed commits and reviewed in c4f1221.

@samueljlieber samueljlieber marked this pull request as ready for review August 11, 2023 18:34
@C3POdoo C3POdoo requested a review from a team August 11, 2023 18:35
toaa-odoo
toaa-odoo requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@toaa-odoo toaa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your hard work, it's a rather long PR. I made some suggestions and comments, some of which could use a clear-up.

General comments are:

  • Removed a few .PNGs (that IMO were not necessary)
  • Changed some of the phrasing
  • Expanded on some menu pathing
  • We no longer :center: pictures (Guidelines may not be updated yet)
  • Redundancy between :ref:'s list and heading menu

Please have a look at some of the comments as I made some changes (from what I could understand, but meaning may have gotten lost in translation) :)

content/applications/finance/fiscal_localizations/colombia.rst Show resolved Hide resolved
content/applications/finance/fiscal_localizations/colombia.rst Outdated Show resolved Hide resolved
content/applications/finance/fiscal_localizations/colombia.rst Outdated Show resolved Hide resolved
content/applications/finance/fiscal_localizations/colombia.rst Show resolved Hide resolved
content/applications/finance/fiscal_localizations/colombia.rst Outdated Show resolved Hide resolved
content/applications/finance/fiscal_localizations/colombia.rst Outdated Show resolved Hide resolved
@samueljlieber samueljlieber force-pushed the 14.0-l10n-co-content-updates-sali branch from d58964f to aa99382 Compare August 18, 2023 18:01
@samueljlieber
Copy link
Contributor Author

Hi @toaa-odoo thank you for your review and suggestions for improvement. I implemented your improvements and made changes for each of your comments in aa99382 🙂

@toaa-odoo toaa-odoo requested a review from a team August 22, 2023 07:58
@samueljlieber samueljlieber force-pushed the 14.0-l10n-co-content-updates-sali branch from aa99382 to 3b557e9 Compare August 31, 2023 14:13
@samueljlieber
Copy link
Contributor Author

Hi @xpl-odoo, thank you for your initial review! I've worked with the team to revise this PR. I removed a large number of images in place of descriptive text as well as added additional contextual information where needed in 3b557e9.

@StraubCreative
Copy link
Contributor

Rebased on b676d50

This is ready for another look, please @xpl-odoo 🙏

@xpl-odoo
Copy link
Contributor

Rebased on b676d50

This is ready for another look, please @xpl-odoo 🙏

Let's proceed as for the MX localization and improve afterward.
@robodoo delegate+

@samueljlieber
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 15, 2023
@samueljlieber @StraubCreative
[IMP] l10n: CO content updates
897ddfe 
closes #4425

Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
@robodoo robodoo temporarily deployed to merge September 15, 2023 14:45 Inactive
@robodoo robodoo closed this Sep 15, 2023
@fw-bot fw-bot mentioned this pull request Sep 15, 2023
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Sep 19, 2023

@samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

This was referenced Sep 19, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@samueljlieber samueljlieber mentioned this pull request Sep 26, 2023
Closed
This was referenced Nov 22, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toaa-odoo toaa-odoo toaa-odoo approved these changes

@StraubCreative StraubCreative Awaiting requested review from StraubCreative

@xpl-odoo xpl-odoo Awaiting requested review from xpl-odoo

Assignees

@samueljlieber samueljlieber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samueljlieber @robodoo @StraubCreative @xpl-odoo @fw-bot @toaa-odoo