Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] events: update track and manage talks #9223

Closed
wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 6, 2024

PROJECT TASK: https://www.odoo.com/web#id=3915122&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

This PR discuss what the Talks, Talk Proposals, and Agenda event website pages entail -- and how to utilize and navigate them.
This is meant as a supplemental PR to the 'Create event tracks' doc...which is focused more on the backend elements and how to create tracks for an event.

This PR should be published/merged after the 'event_tracks' PR
That's why there is likely going to be continued Build Errors -- because that 'event_tracks' doc is referenced in the seealso at the end.

I worked off the original RST file name so that I didn't ruin any potential reference links that could be lingering elsewhere...

@ksc-odoo ksc-odoo self-assigned this May 6, 2024
@ksc-odoo ksc-odoo marked this pull request as draft May 6, 2024 22:33
@robodoo
Copy link
Collaborator

robodoo commented May 6, 2024

@ksc-odoo ksc-odoo force-pushed the 17.0-events-update-track-manage-talks-ksc branch from 77cbd32 to babbc87 Compare May 7, 2024 20:31
@ksc-odoo ksc-odoo added the 5 label May 7, 2024
@ksc-odoo ksc-odoo force-pushed the 17.0-events-update-track-manage-talks-ksc branch from babbc87 to fbbdc47 Compare May 8, 2024 13:23
@ksc-odoo ksc-odoo marked this pull request as ready for review May 8, 2024 13:24
@C3POdoo C3POdoo requested a review from a team May 8, 2024 13:29
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented May 8, 2024

Hey @brse-odoo -- this one is ready for Peer Review whenever you get a chance...Thanks! 👍

@ksc-odoo ksc-odoo requested a review from brse-odoo May 8, 2024 13:57
Copy link
Contributor

@brse-odoo brse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo I've finished my review of this PR, great job! Very informative and easy to follow. I'm approving with some suggestions for you to accept/reject as you see fit. Let me know if you have any questions, thanks!

@ksc-odoo ksc-odoo force-pushed the 17.0-events-update-track-manage-talks-ksc branch from fbbdc47 to 78beba2 Compare May 14, 2024 14:16
@ksc-odoo
Copy link
Contributor Author

Thanks for the super-helpful feedback, @brse-odoo -- made all your suggested edits 👍 This one is now ready for Final Review @StraubCreative -- whenever you get a chance. Thanks! 🙏

@ksc-odoo ksc-odoo force-pushed the 17.0-events-update-track-manage-talks-ksc branch from 78beba2 to 8bd319f Compare May 20, 2024 14:49
@StraubCreative StraubCreative force-pushed the 17.0-events-update-track-manage-talks-ksc branch from 8bd319f to d772c91 Compare June 17, 2024 23:58
@StraubCreative
Copy link
Contributor

Rebase to latest on d772c91

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo

Looks good, I like how you focused the content to be more specific to talks instead of the other topics that were included in the previous iteration (Attendees, LGR, etc.)

I just had a few comments below for you to look at. Once they're addressed to your liking feel free to move on to tech review.

Cheers!

@ksc-odoo ksc-odoo force-pushed the 17.0-events-update-track-manage-talks-ksc branch from d772c91 to e414922 Compare June 28, 2024 17:03
@ksc-odoo
Copy link
Contributor Author

Thanks again for the awesome feedback/suggestions, @StraubCreative -- really appreciate it! I made all those necessary adjustments, and believe this one is now ready for Tech Review, @samueljlieber 🫡

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! Nice work on this full rewrite of the events tracks documentation. Your improvements look great, approving with a quick fix! Thanks!
.....
@robodoo delegate=ksc-odoo

@ksc-odoo ksc-odoo force-pushed the 17.0-events-update-track-manage-talks-ksc branch from e414922 to 7e23c64 Compare July 5, 2024 20:41
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jul 5, 2024

Thanks for the feedback, @samueljlieber -- made that quick adjustment, and believe this one is ready to go. Thanks again! 👍

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants