Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] events: added an event tracks doc #9241

Closed
wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 8, 2024

PROJECT TASK: https://www.odoo.com/web#id=3919221&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

This PR breaks down everything there is to know about Event Tracks and how to create them in Odoo Events.
Completely new doc, new screenshots...etc.

This should be published/merged before the Track_Manage_Talks doc

@ksc-odoo ksc-odoo added the 5 label May 8, 2024
@ksc-odoo ksc-odoo self-assigned this May 8, 2024
@robodoo
Copy link
Collaborator

robodoo commented May 8, 2024

@C3POdoo C3POdoo requested a review from a team May 8, 2024 13:49
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented May 8, 2024

Hey @tiku-odoo -- this one is ready for a Peer Review whenever you get a chance. Thanks 👍

@ksc-odoo ksc-odoo requested a review from tiku-odoo May 8, 2024 13:56
Copy link
Contributor

@tiku-odoo tiku-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo

Great new document on track configuration.

I've made a few suggestions, for your consideration.

I noticed a few build errors- for some reason we need to manually add the images to docs now. Also this doc needs to be added to the toc tree.

Great work on this doc, looking forward to seeing it published.

Let me know if you have any questions.

👍
Tim

content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-tracks-ksc branch from 3b501fd to 37ddb53 Compare May 14, 2024 13:49
@ksc-odoo
Copy link
Contributor Author

Thanks for the always-helpful review, @tiku-odoo -- made all your suggested edits. 👍 This one is ready for a Final Review @StraubCreative -- whenever you get a chance... 🙏

@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-tracks-ksc branch from 37ddb53 to eea5e15 Compare May 14, 2024 14:27
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-tracks-ksc branch 2 times, most recently from 090696b to 528dd67 Compare May 20, 2024 17:29
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo

Please clean up the "user" language throughout the doc, as I see a lot of it on the page and it's distracting for me to understand what's being written and overall unnecessary since we're writing about an app/software (not people):

  • The users label is no different than using regular pronouns, which generally isn't necessary when we're talking about software (unless certain situations like user config) + adds word spam to the page.
  • consumer-based labels like this strip people of their complexity and reduces them to shopping inputs/outputs, which speaks to the opposite of open-source values/methodology

Can tag me again for review after (if you agree), or we can discuss it further if you like (just lmk), thanks!

image

content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-tracks-ksc branch from 528dd67 to bf31667 Compare May 30, 2024 20:46
@ksc-odoo
Copy link
Contributor Author

Thanks for the feedback, @StraubCreative -- I made all the adjustments you requested, and am tagging you for another look (whenever you get the chance) Thanks! 👍

@larm-odoo larm-odoo self-requested a review July 8, 2024 20:17
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo - great doc! I didn't know we had event tracks =)

I just had a handful of suggestions - they are all optional. Any questions, just let me know!

content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
@StraubCreative StraubCreative removed their request for review July 10, 2024 20:38
@StraubCreative
Copy link
Contributor

@ksc-odoo to merge this in please address @larm-odoo feedback and pass to @samueljlieber after. Does not need another review from me, thank you!

@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-tracks-ksc branch 2 times, most recently from 8f202a0 to f8e2a57 Compare July 11, 2024 17:40
@ksc-odoo
Copy link
Contributor Author

Thanks for the feedback, @larm-odoo -- I made those suggested edits, and think this one is now ready for Tech Review @samueljlieber -- 👍

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! Nice work on this new Events doc on Tracks. I think you covered them very well 👏 Approving with a couple fixes and suggestions. Thank you for your work!

Suggestion to add card to events.rst:

   .. card:: Talks, proposals, and agenda
      :target: events/track_manage_talks

      View talks, agendas, and propose a talk.

   .. card:: Event Tracks
      :target: events/event_tracks

      Learn how to create, track, and manage event tracks with Odoo.

Thank!
.....
@robodoo delegate=ksc-odoo

content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/event_tracks.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-event-tracks-ksc branch from f8e2a57 to 260a419 Compare July 18, 2024 23:07
@ksc-odoo
Copy link
Contributor Author

Thanks for the super-helpful feedback, @samueljlieber -- I really appreciate it. 🙏

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants