-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] events: added an event tracks doc #9241
Conversation
Hey @tiku-odoo -- this one is ready for a Peer Review whenever you get a chance. Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great new document on track configuration.
I've made a few suggestions, for your consideration.
I noticed a few build errors- for some reason we need to manually add the images to docs now. Also this doc needs to be added to the toc tree.
Great work on this doc, looking forward to seeing it published.
Let me know if you have any questions.
👍
Tim
3b501fd
to
37ddb53
Compare
Thanks for the always-helpful review, @tiku-odoo -- made all your suggested edits. 👍 This one is ready for a Final Review @StraubCreative -- whenever you get a chance... 🙏 |
37ddb53
to
eea5e15
Compare
090696b
to
528dd67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksc-odoo
Please clean up the "user" language throughout the doc, as I see a lot of it on the page and it's distracting for me to understand what's being written and overall unnecessary since we're writing about an app/software (not people):
- The users label is no different than using regular pronouns, which generally isn't necessary when we're talking about software (unless certain situations like user config) + adds word spam to the page.
- consumer-based labels like this strip people of their complexity and reduces them to shopping inputs/outputs, which speaks to the opposite of open-source values/methodology
Can tag me again for review after (if you agree), or we can discuss it further if you like (just lmk), thanks!
528dd67
to
bf31667
Compare
Thanks for the feedback, @StraubCreative -- I made all the adjustments you requested, and am tagging you for another look (whenever you get the chance) Thanks! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksc-odoo - great doc! I didn't know we had event tracks =)
I just had a handful of suggestions - they are all optional. Any questions, just let me know!
@ksc-odoo to merge this in please address @larm-odoo feedback and pass to @samueljlieber after. Does not need another review from me, thank you! |
8f202a0
to
f8e2a57
Compare
Thanks for the feedback, @larm-odoo -- I made those suggested edits, and think this one is now ready for Tech Review @samueljlieber -- 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksc-odoo! Nice work on this new Events doc on Tracks. I think you covered them very well 👏 Approving with a couple fixes and suggestions. Thank you for your work!
Suggestion to add card to events.rst
:
.. card:: Talks, proposals, and agenda
:target: events/track_manage_talks
View talks, agendas, and propose a talk.
.. card:: Event Tracks
:target: events/event_tracks
Learn how to create, track, and manage event tracks with Odoo.
Thank!
.....
@robodoo delegate=ksc-odoo
f8e2a57
to
260a419
Compare
Thanks for the super-helpful feedback, @samueljlieber -- I really appreciate it. 🙏 @robodoo r+ |
PROJECT TASK: https://www.odoo.com/web#id=3919221&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form
This PR breaks down everything there is to know about Event Tracks and how to create them in Odoo Events.
Completely new doc, new screenshots...etc.
This should be published/merged before the Track_Manage_Talks doc