Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] XLSX: Update the list of 'future' functions of Excel #4542

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 2, 2024

The list of non-retrocompatible (aka future) functions of excel we had hardcoded was outdated. As it already contained some functions that we did not support inside the library, it is easier to update the list completely in each supported version.

Task: 4017114

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4539

@robodoo
Copy link
Collaborator

robodoo commented Jul 2, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 2, 2024

This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 2, 2024

@rrahir @hokolomopo ci/runbot failed on this forward-port PR

The list of non-retrocompatible (aka future) functions of excel we had
hardcoded was outdated. As it already contained some functions that we
did not support inside the library, it is easier to update the list
completely in each supported version.

Task: 4017114
X-original-commit: 48c4a9a
@rrahir rrahir force-pushed the saas-16.4-15.0-update-excel-future-functions-rar-GUkG-fw branch from 079e563 to 2bacd7d Compare July 2, 2024 09:14
@rrahir
Copy link
Collaborator

rrahir commented Jul 2, 2024

@robodoo r+

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 2, 2024

@rrahir @hokolomopo this PR was modified / updated and has become a normal PR. It must be merged directly.

robodoo pushed a commit that referenced this pull request Jul 2, 2024
The list of non-retrocompatible (aka future) functions of excel we had
hardcoded was outdated. As it already contained some functions that we
did not support inside the library, it is easier to update the list
completely in each supported version.

closes #4542

Task: 4017114
X-original-commit: 48c4a9a
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Jul 2, 2024
@fw-bot fw-bot deleted the saas-16.4-15.0-update-excel-future-functions-rar-GUkG-fw branch July 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants