Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] TopBar: Remove hidden functions from the insert menu #3842

Closed

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Mar 15, 2024

The introduction of the hidden tag of functions in pr #1928 did not account for the insert function menu of the top bar that was developped at the same time.

This revision ensures that the functions marked as hidden do not appear in the top bar menu, similarly to their behaviour in the composer formula autocomplete assistant.

Task: 3810284

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Mar 15, 2024

The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
@rrahir rrahir force-pushed the saas-16.3-filter-hidden-formula-from-insert-rar branch from b9a7df9 to 6edec77 Compare March 18, 2024 09:27
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 21, 2024
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3842

Task: 3810284
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Mar 21, 2024
@fw-bot fw-bot deleted the saas-16.3-filter-hidden-formula-from-insert-rar branch April 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants