Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Function: add hidden tag to hide functions #1928

Closed
wants to merge 1 commit into from
Closed

[IMP] Function: add hidden tag to hide functions #1928

wants to merge 1 commit into from

Conversation

yunchen4
Copy link

@yunchen4 yunchen4 commented Jan 3, 2023

Description:

This PR adds the tag hidden to hide some functions to users, so users will not have the chance to see their existences.

Odoo task ID : 3102309

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 3, 2023

Pull request status dashboard.

@yunchen4 yunchen4 marked this pull request as draft January 4, 2023 08:47
@yunchen4 yunchen4 marked this pull request as ready for review January 4, 2023 09:06
@yunchen4 yunchen4 force-pushed the master-function-add-hidden-tag-chya branch from fa607cf to 419e93c Compare January 10, 2023 08:07
@yunchen4 yunchen4 force-pushed the master-function-add-hidden-tag-chya branch 3 times, most recently from aab15ca to 90e1dae Compare January 13, 2023 12:15
@yunchen4 yunchen4 force-pushed the master-function-add-hidden-tag-chya branch from 90e1dae to ee4dbe6 Compare January 27, 2023 09:36
@LucasLefevre
[IMP] Function: add hidden tag to hide functions
53be688 
This commit adds the tag `hidden` to hide some functions to users, so users
will not have the chance to see their existences.

task 3102309
@LucasLefevre LucasLefevre force-pushed the master-function-add-hidden-tag-chya branch from ee4dbe6 to 53be688 Compare January 30, 2023 12:40
LucasLefevre
LucasLefevre approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(I applied my comment)
Side note about commit messages: the line length shouldn't be above ~80 characters 😉
robodoo r+

src/types/functions.ts Outdated
}

export interface FunctionDescription extends AddFunctionDescription {
minArgRequired: number;
maxArgPossible: number;
nbrArgRepeating: number;
getArgToFocus: (argPosition: number) => number;
hidden?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not useful since it extends AddFunctionDescription which has the same property definition

@robodoo robodoo closed this in d811b1f Jan 30, 2023
@robodoo robodoo temporarily deployed to merge January 30, 2023 14:45 Inactive
@robodoo robodoo added the 16.2 label Jan 30, 2023
@fw-bot fw-bot deleted the master-function-add-hidden-tag-chya branch February 13, 2023 14:46
@rrahir rrahir mentioned this pull request Mar 15, 2024
Closed
14 tasks
rrahir added a commit that referenced this pull request Mar 18, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
6edec77 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
robodoo pushed a commit that referenced this pull request Mar 21, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
f883740 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3842

Task: 3810284
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
fw-bot pushed a commit that referenced this pull request Mar 21, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
8194211 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
X-original-commit: f883740
@fw-bot fw-bot mentioned this pull request Mar 21, 2024
Closed
14 tasks
fw-bot pushed a commit that referenced this pull request Mar 21, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
ffe02fc 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
X-original-commit: f883740
@fw-bot fw-bot mentioned this pull request Mar 21, 2024
Closed
14 tasks
fw-bot pushed a commit that referenced this pull request Mar 21, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
7050398 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
X-original-commit: f883740
@fw-bot fw-bot mentioned this pull request Mar 21, 2024
Closed
14 tasks
@fw-bot fw-bot mentioned this pull request Mar 21, 2024
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
d80196f 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3872

Task: 3810284
X-original-commit: f883740
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
5727085 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3877

Task: 3810284
X-original-commit: f883740
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
2f96ca0 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3875

Task: 3810284
X-original-commit: f883740
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
rrahir added a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
f618707 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
X-original-commit: f883740
robodoo pushed a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
4894703 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3878

Task: 3810284
X-original-commit: f883740
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
fw-bot pushed a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
78a0c1c 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
X-original-commit: 4894703
@fw-bot fw-bot mentioned this pull request Mar 22, 2024
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Mar 22, 2024
@rrahir
[FIX] TopBar: Remove hidden functions from the insert menu
62d99cd 
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3885

Task: 3810284
X-original-commit: 4894703
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
16.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunchen4 @robodoo @LucasLefevre