Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] TopBar: Remove hidden functions from the insert menu #3885

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 22, 2024

The introduction of the hidden tag of functions in pr #1928 did not account for the insert function menu of the top bar that was developped at the same time.

This revision ensures that the functions marked as hidden do not appear in the top bar menu, similarly to their behaviour in the composer formula autocomplete assistant.

Task: 3810284

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3878
Forward-Port-Of: #3842

The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

Task: 3810284
X-original-commit: 4894703
@robodoo
Copy link
Collaborator

robodoo commented Mar 22, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 22, 2024

@rrahir @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rrahir
Copy link
Collaborator

rrahir commented Mar 22, 2024

@fw-bot r+

robodoo pushed a commit that referenced this pull request Mar 22, 2024
The introduction of the `hidden` tag of functions in pr #1928 did not
account for the `insert function` menu of the top bar that was
developped at the same time.

This revision ensures that the functions marked as `hidden` do not
appear in the top bar menu, similarly to their behaviour in the composer
formula autocomplete assistant.

closes #3885

Task: 3810284
X-original-commit: 4894703
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Mar 22, 2024
@robodoo robodoo added the 17.3 label Mar 22, 2024
@fw-bot fw-bot deleted the master-saas-16.3-filter-hidden-formula-from-insert-rar-kLpk-fw branch April 5, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants