Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] menu: non-aligned menu items #3855

Closed
wants to merge 1 commit into from
Closed

Conversation

hokolomopo
Copy link
Contributor

Description

If the menu items were too long, and that the menu item had a blank space in place of an icon, the menu texts were not aligned properly because of a flex shrink.

Task: : 3814222

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Mar 18, 2024

If the menu items were too long, and that the menu item had a blank
space in place of an icon, the menu texts were not aligned properly
because of a flex shrink.

Task: 3814222
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+
I updated the snapshots

@fw-bot
Copy link
Collaborator

fw-bot commented Mar 29, 2024

@hokolomopo @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot fw-bot deleted the 17.0-menu-item-align-adrm branch April 8, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants