Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] menu: non-aligned menu items #3917

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 25, 2024

Description

If the menu items were too long, and that the menu item had a blank space in place of an icon, the menu texts were not aligned properly because of a flex shrink.

Task: : 3814222

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3906
Forward-Port-Of: #3855

If the menu items were too long, and that the menu item had a blank
space in place of an icon, the menu texts were not aligned properly
because of a flex shrink.

Task: 3814222
X-original-commit: d485705
@robodoo
Copy link
Collaborator

robodoo commented Mar 25, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 25, 2024

@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 25, 2024
If the menu items were too long, and that the menu item had a blank
space in place of an icon, the menu texts were not aligned properly
because of a flex shrink.

closes #3917

Task: 3814222
X-original-commit: d485705
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Mar 25, 2024
@robodoo robodoo added the 17.3 label Mar 25, 2024
@fw-bot fw-bot deleted the master-17.0-menu-item-align-adrm-sEKZ-fw branch April 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants