[FW][FIX] menu: non-aligned menu items #3906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@hokolomopo @LucasLefevre ci/runbot failed on this forward-port PR |
If the menu items were too long, and that the menu item had a blank space in place of an icon, the menu texts were not aligned properly because of a flex shrink. Task: 3814222 X-original-commit: 261616d
hokolomopo
force-pushed
the
saas-17.1-17.0-menu-item-align-adrm-dvFG-fw
branch
from
cd3b069
to
fb96612
Compare
|
@hokolomopo @LucasLefevre this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
If the menu items were too long, and that the menu item had a blank space in place of an icon, the menu texts were not aligned properly because of a flex shrink. closes #3906 Task: 3814222 X-original-commit: 261616d Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the menu items were too long, and that the menu item had a blank space in place of an icon, the menu texts were not aligned properly because of a flex shrink.
Task: : 3814222
review checklist
Forward-Port-Of: #3855