[FIX] export: export non-Excel formulas as value

[Dj0ulo]

Current behavior before commit:
Since the commit 201aea7, when formulaCell is a FormulaCellWithDependencies, content might be set to raw formula even if it is not readable by Excel.

Description of the fix:
Prevent content to be set to the raw formula if isFormula === false.

Example of steps to reproduce the issue:

• Write a number in A1
• Write =FORMAT.LARGE.NUMBER(A1) in A2
• Save as XLSX and open in Excel -> A2 is not evaluated by Excel

opw-3782676

review checklist

• feature is organized in plugin, or UI components
• support of duplicate sheet (deep copy)
• in model/core: ranges are Range object, and can be adapted (adaptRanges)
• in model/UI: ranges are strings (to show the user)
• undo-able commands (uses this.history.update)
• multiuser-able commands (has inverse commands and transformations where needed)
• new/updated/removed commands are documented
• exportable in excel
• translations (_t("qmsdf %s", abc))
• unit tested
• clean commented code
• track breaking changes
• doc is rebuild (npm run doc)
• status is correct in Odoo

[robodoo]

Pull request status dashboard.

[VincentSchippefilt]

Hello @Dj0ulo,
I'm looking into why our tests didn't fail. there is something strange happening with some formulas that I need to check. I'll push on this branch the test adaptation :)

[VincentSchippefilt]

@Dj0ulo I amended a commit in your branch with a test that shows that formulas with dependencies where exported incorrectly before your fix, and correct after your fix. Thank you for your work :)

[VincentSchippefilt]

robodoo r+

[Dj0ulo]

Nice, thanks for the review!

[fw-bot]

@Dj0ulo @VincentSchippefilt this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] export: export non-Excel formulas as value #3874