[FW][FIX] export: export non-Excel formulas as value #3903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Current behavior before commit:__ Since the commit [`201aea7`][1], when `formulaCell` is a `FormulaCellWithDependencies`, `content` might be set to raw formula even if it is not readable by Excel. __Description of the fix:__ Prevent `content` to be set to the raw formula if `isFormula === false`. __Example of steps to reproduce the issue:__ - Write a number in **A1** - Write `=FORMAT.LARGE.NUMBER(A1)` in **A2** - Save as XLSX and open in Excel -> **A2** is not evaluated by Excel opw-3782676 [1]: 201aea7 X-original-commit: e4d2bd8
|
@Dj0ulo @VincentSchippefilt this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
__Current behavior before commit:__ Since the commit [`201aea7`][1], when `formulaCell` is a `FormulaCellWithDependencies`, `content` might be set to raw formula even if it is not readable by Excel. __Description of the fix:__ Prevent `content` to be set to the raw formula if `isFormula === false`. __Example of steps to reproduce the issue:__ - Write a number in **A1** - Write `=FORMAT.LARGE.NUMBER(A1)` in **A2** - Save as XLSX and open in Excel -> **A2** is not evaluated by Excel opw-3782676 [1]: 201aea7 closes #3903 X-original-commit: e4d2bd8 Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
fw-bot
deleted the
master-17.0-export-export-non-Excel-formulas-as-value-jula-8OnR-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior before commit:
Since the commit
201aea7, whenformulaCellis aFormulaCellWithDependencies,contentmight be set to raw formula even if it is not readable by Excel.Description of the fix:
Prevent
contentto be set to the raw formula ifisFormula === false.Example of steps to reproduce the issue:
=FORMAT.LARGE.NUMBER(A1)in A2opw-3782676
review checklist
Forward-Port-Of: #3874
Forward-Port-Of: #3856