New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] export: export non-Excel formulas as value #3874
[FW][FIX] export: export non-Excel formulas as value #3874
Conversation
@Dj0ulo @VincentSchippefilt cherrypicking of pull request #3856 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
__Current behavior before commit:__ Since the commit [`201aea7`][1], when `formulaCell` is a `FormulaCellWithDependencies`, `content` might be set to raw formula even if it is not readable by Excel. __Description of the fix:__ Prevent `content` to be set to the raw formula if `isFormula === false`. __Example of steps to reproduce the issue:__ - Write a number in **A1** - Write `=FORMAT.LARGE.NUMBER(A1)` in **A2** - Save as XLSX and open in Excel -> **A2** is not evaluated by Excel opw-3782676 [1]: 201aea7 X-original-commit: fe4ffe1
58b1f98
to
ea4d4ab
Compare
robodoo r+ |
__Current behavior before commit:__ Since the commit [`201aea7`][1], when `formulaCell` is a `FormulaCellWithDependencies`, `content` might be set to raw formula even if it is not readable by Excel. __Description of the fix:__ Prevent `content` to be set to the raw formula if `isFormula === false`. __Example of steps to reproduce the issue:__ - Write a number in **A1** - Write `=FORMAT.LARGE.NUMBER(A1)` in **A2** - Save as XLSX and open in Excel -> **A2** is not evaluated by Excel opw-3782676 [1]: 201aea7 closes #3874 X-original-commit: fe4ffe1 Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Current behavior before commit:
Since the commit
201aea7
, whenformulaCell
is aFormulaCellWithDependencies
,content
might be set to raw formula even if it is not readable by Excel.Description of the fix:
Prevent
content
to be set to the raw formula ifisFormula === false
.Example of steps to reproduce the issue:
=FORMAT.LARGE.NUMBER(A1)
in A2opw-3782676
review checklist
Forward-Port-Of: #3856