Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] export: export non-Excel formulas as value #3874

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 21, 2024

Current behavior before commit:
Since the commit 201aea7, when formulaCell is a FormulaCellWithDependencies, content might be set to raw formula even if it is not readable by Excel.

Description of the fix:
Prevent content to be set to the raw formula if isFormula === false.

Example of steps to reproduce the issue:

  • Write a number in A1
  • Write =FORMAT.LARGE.NUMBER(A1) in A2
  • Save as XLSX and open in Excel -> A2 is not evaluated by Excel

opw-3782676

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3856

@robodoo
Copy link
Collaborator

robodoo commented Mar 21, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 21, 2024

@Dj0ulo @VincentSchippefilt cherrypicking of pull request #3856 failed.

stdout:

Auto-merging src/plugins/ui_core_views/cell_evaluation/evaluation_plugin.ts
CONFLICT (content): Merge conflict in src/plugins/ui_core_views/cell_evaluation/evaluation_plugin.ts
Auto-merging tests/xlsx/__snapshots__/xlsx_export.test.ts.snap
CONFLICT (content): Merge conflict in tests/xlsx/__snapshots__/xlsx_export.test.ts.snap
Auto-merging tests/xlsx/xlsx_export.test.ts

stderr:

16:16:06.152849 git.c:463               trace: built-in: git cherry-pick fb0400d9def19564cab55547595497657f6fab5d
error: could not apply fb0400d9d... [FIX] export: export non-Excel formulas as value
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

__Current behavior before commit:__
Since the commit [`201aea7`][1], when `formulaCell` is a
`FormulaCellWithDependencies`, `content` might be set to raw formula
even if it is not readable by Excel.

__Description of the fix:__
Prevent `content` to be set to the raw formula if `isFormula === false`.

__Example of steps to reproduce the issue:__
- Write a number in **A1**
- Write `=FORMAT.LARGE.NUMBER(A1)` in **A2**
- Save as XLSX and open in Excel
-> **A2** is not evaluated by Excel

opw-3782676

[1]: 201aea7

X-original-commit: fe4ffe1
@VincentSchippefilt VincentSchippefilt force-pushed the saas-17.1-17.0-export-export-non-Excel-formulas-as-value-jula-2WDK-fw branch from 58b1f98 to ea4d4ab Compare March 25, 2024 10:30
@VincentSchippefilt
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 25, 2024
__Current behavior before commit:__
Since the commit [`201aea7`][1], when `formulaCell` is a
`FormulaCellWithDependencies`, `content` might be set to raw formula
even if it is not readable by Excel.

__Description of the fix:__
Prevent `content` to be set to the raw formula if `isFormula === false`.

__Example of steps to reproduce the issue:__
- Write a number in **A1**
- Write `=FORMAT.LARGE.NUMBER(A1)` in **A2**
- Save as XLSX and open in Excel
-> **A2** is not evaluated by Excel

opw-3782676

[1]: 201aea7

closes #3874

X-original-commit: fe4ffe1
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
@robodoo robodoo closed this Mar 25, 2024
@fw-bot fw-bot deleted the saas-17.1-17.0-export-export-non-Excel-formulas-as-value-jula-2WDK-fw branch April 8, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants