Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] chart: wrong line dot size #4156

Closed
wants to merge 2 commits into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 29, 2024

[FIX] chart: wrong line dot size

There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.

[FIX] chart: avoid useless chart updates

There was an useEffect in the chartJS component to update the
chartJS object on runtime change. There was 2 problems:

  1. useEffect on object compare the references, so if the chart plugin
    was ever changed to return copy of runtime it would break
  2. the chart plugin re-build every chartRuntime on each command that
    could affect a chart. This created a chart update at each UPDATE_CELL
    even if the actual runtime didn't change.

This commit replace the useEffect dependency with a deepEquals

Task: : 3697660

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4066

@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2024

@fw-bot fw-bot mentioned this pull request Apr 29, 2024
14 tasks
@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 29, 2024

@hokolomopo @pro-odoo cherrypicking of pull request #4066 failed.

stdout:

Auto-merging src/components/figures/chart/chartJs/chartjs.ts
CONFLICT (content): Merge conflict in src/components/figures/chart/chartJs/chartjs.ts

stderr:

13:43:06.516497 git.c:463               trace: built-in: git cherry-pick 1e77ddb43c4ae0cc42b974667e50a02b34cf9487
error: could not apply 1e77ddb43... [FIX] chart: wrong line dot size
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.

Task: 3697660
There was an `useEffect` in the `chartJS` component to update the
chartJS object on runtime change. There was 2 problems:

1) useEffect on object compare the references, so if the chart plugin
was ever changed to return copy of runtime it would break
2) the chart plugin re-build every chartRuntime on each command that
could affect a chart. This created a chart update at each UPDATE_CELL
even if the actual runtime didn't change.

This commit replace the `useEffect` dependency with a `deepEquals`

Task: 3697660
@hokolomopo hokolomopo force-pushed the master-17.0-chartjs-dot-size-adrm-VnSY-fw branch from 8994a91 to ecd03d6 Compare April 29, 2024 12:31
@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 29, 2024
There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.

Task: 3697660
Part-of: #4156
robodoo pushed a commit that referenced this pull request Apr 29, 2024
There was an `useEffect` in the `chartJS` component to update the
chartJS object on runtime change. There was 2 problems:

1) useEffect on object compare the references, so if the chart plugin
was ever changed to return copy of runtime it would break
2) the chart plugin re-build every chartRuntime on each command that
could affect a chart. This created a chart update at each UPDATE_CELL
even if the actual runtime didn't change.

This commit replace the `useEffect` dependency with a `deepEquals`

closes #4156

Task: 3697660
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Apr 29, 2024
@robodoo robodoo added the 17.3 label Apr 29, 2024
@fw-bot fw-bot deleted the master-17.0-chartjs-dot-size-adrm-VnSY-fw branch May 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants