[FW][FIX] chart: wrong line dot size #4155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem that the doz sizes in the line charts were at their "hover" size by default. This was caused by the "active" parameters given to window.chart.update(), which updated the chart animations to be in "active" state. Task: 3697660 X-original-commit: 5cc411f
There was an `useEffect` in the `chartJS` component to update the chartJS object on runtime change. There was 2 problems: 1) useEffect on object compare the references, so if the chart plugin was ever changed to return copy of runtime it would break 2) the chart plugin re-build every chartRuntime on each command that could affect a chart. This created a chart update at each UPDATE_CELL even if the actual runtime didn't change. This commit replace the `useEffect` dependency with a `deepEquals` Task: 3697660 X-original-commit: 6eb4353
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@hokolomopo @pro-odoo the next pull request (#4156) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+
…On Mon, Apr 29, 2024 at 1:43 PM Otis - Odoo Forward-Port Steward [bot] < ***@***.***> wrote:
@hokolomopo <https://github.com/hokolomopo> @pro-odoo
<https://github.com/pro-odoo> the next pull request (#4156
<#4156>) is in conflict. You
can merge the chain up to here by saying
@fw-bot <https://github.com/fw-bot> r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
—
Reply to this email directly, view it on GitHub
<#4155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHFIBHXWM2JEIFRJKBQXTFTY7YW6RAVCNFSM6AAAAABG6EUK42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGUYDEMBRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
There was an `useEffect` in the `chartJS` component to update the chartJS object on runtime change. There was 2 problems: 1) useEffect on object compare the references, so if the chart plugin was ever changed to return copy of runtime it would break 2) the chart plugin re-build every chartRuntime on each command that could affect a chart. This created a chart update at each UPDATE_CELL even if the actual runtime didn't change. This commit replace the `useEffect` dependency with a `deepEquals` closes #4155 Task: 3697660 X-original-commit: 6eb4353 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] chart: wrong line dot size
There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.
[FIX] chart: avoid useless chart updates
There was an
useEffectin thechartJScomponent to update thechartJS object on runtime change. There was 2 problems:
was ever changed to return copy of runtime it would break
could affect a chart. This created a chart update at each UPDATE_CELL
even if the actual runtime didn't change.
This commit replace the
useEffectdependency with adeepEqualsTask: : 3697660
review checklist
Forward-Port-Of: #4066