Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] chart: wrong line dot size #4066

Closed
wants to merge 2 commits into from
Closed

Conversation

hokolomopo
Copy link
Contributor

[FIX] chart: wrong line dot size

There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.

[FIX] chart: avoid useless chart updates

There was an useEffect in the chartJS component to update the
chartJS object on runtime change. There was 2 problems:

  1. useEffect on object compare the references, so if the chart plugin
    was ever changed to return copy of runtime it would break
  2. the chart plugin re-build every chartRuntime on each command that
    could affect a chart. This created a chart update at each UPDATE_CELL
    even if the actual runtime didn't change.

This commit replace the useEffect dependency with a deepEquals

Task: : 3697660

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.

Task: 3697660
@robodoo
Copy link
Collaborator

robodoo commented Apr 15, 2024

There was an `useEffect` in the `chartJS` component to update the
chartJS object on runtime change. There was 2 problems:

1) useEffect on object compare the references, so if the chart plugin
was ever changed to return copy of runtime it would break
2) the chart plugin re-build every chartRuntime on each command that
could affect a chart. This created a chart update at each UPDATE_CELL
even if the actual runtime didn't change.

This commit replace the `useEffect` dependency with a `deepEquals`

Task: 3697660
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo rebase-ff r+

@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2024

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Apr 29, 2024
There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.

Task: 3697660
Part-of: #4066
@robodoo robodoo closed this in 6eb4353 Apr 29, 2024
@fw-bot fw-bot mentioned this pull request Apr 29, 2024
14 tasks
@fw-bot fw-bot deleted the 17.0-chartjs-dot-size-adrm branch May 13, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants