-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] chart: wrong line dot size #4066
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem that the doz sizes in the line charts were at their "hover" size by default. This was caused by the "active" parameters given to window.chart.update(), which updated the chart animations to be in "active" state. Task: 3697660
hokolomopo
force-pushed
the
17.0-chartjs-dot-size-adrm
branch
from
April 18, 2024 06:29
77db047
to
171f79b
Compare
pro-odoo
reviewed
Apr 29, 2024
There was an `useEffect` in the `chartJS` component to update the chartJS object on runtime change. There was 2 problems: 1) useEffect on object compare the references, so if the chart plugin was ever changed to return copy of runtime it would break 2) the chart plugin re-build every chartRuntime on each command that could affect a chart. This created a chart update at each UPDATE_CELL even if the actual runtime didn't change. This commit replace the `useEffect` dependency with a `deepEquals` Task: 3697660
hokolomopo
force-pushed
the
17.0-chartjs-dot-size-adrm
branch
from
April 29, 2024 10:49
171f79b
to
4240b73
Compare
pro-odoo
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo rebase-ff r+
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
There was a problem that the doz sizes in the line charts were at their "hover" size by default. This was caused by the "active" parameters given to window.chart.update(), which updated the chart animations to be in "active" state. Task: 3697660 Part-of: #4066
14 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] chart: wrong line dot size
There was a problem that the doz sizes in the line charts were at their
"hover" size by default. This was caused by the "active" parameters
given to window.chart.update(), which updated the chart animations
to be in "active" state.
[FIX] chart: avoid useless chart updates
There was an
useEffect
in thechartJS
component to update thechartJS object on runtime change. There was 2 problems:
was ever changed to return copy of runtime it would break
could affect a chart. This created a chart update at each UPDATE_CELL
even if the actual runtime didn't change.
This commit replace the
useEffect
dependency with adeepEquals
Task: : 3697660
review checklist