Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] web_editor: enter remove or duplicate node
There is some odd behavior especially inside a editable containing newlines. For example in the sale description on an ecommerce item, lines could contain newline (it is editable from backend) but as an effect of other use case, pressing enter could have a range of unwanted side effects: - removing all the content, - duplicating the editable (should never happen, if we have one field "description_sale" we don't want to duplicate it, this has no sense) In a product name which is in the same use case, there is no newline so the problem is not apparent, and ENTER do nothing. This is the behavior we should want in every instance. If we still want a newline, we have to force it with SHIFT + ENTER key, also this is regarding field that may or could be present in the backend views, so it could also be edited in backend. This change make ENTER ignore when we are directly inside an editable. A second part of the issue was that dom.removeBetween (used to remove content inside a range) could remove the ancestor node that was an editable. This is not wanted. For example if we did CTRL + A inside a field with `<br />` then ENTER or pasting something, the field would be removed and not just emptied. This was sometimes mitigated because if a `<br />` was at the end of an element, it would stay in this use case avoiding the issue. fixes #17445 opw-751360 closes #18319
- Loading branch information