Skip to content

Commit

Permalink
[FIX] purchase: update reference onchange of purchase_id
Browse files Browse the repository at this point in the history
Commit 1be873d removed the modification of the reference field
from the _onchange_origin.
The reasoning was that since this is an onchange on invoice_line_ids, it was
applied too often, which annoyed users in the case they overwrote that field.

However when using the "Autocomplete" field (purchase_id),
then the user expects values to by modified.
Before, it worked by setting the origin field, which trickled down
to the reference.
Since that commit removed this, we re-add it explicitly in that case.

opw 1962364

closes #32656

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
  • Loading branch information
Nans Lefebvre committed Apr 11, 2019
1 parent 309f152 commit a441e89
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions addons/purchase/models/account_invoice.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ def purchase_order_change(self):
if not self.partner_id:
self.partner_id = self.purchase_id.partner_id.id

vendor_ref = self.purchase_id.partner_ref
if vendor_ref:
self.reference = ", ".join([self.reference, vendor_ref]) if (
self.reference and vendor_ref not in self.reference) else vendor_ref

new_lines = self.env['account.invoice.line']
for line in self.purchase_id.order_line - self.invoice_line_ids.mapped('purchase_line_id'):
data = self._prepare_invoice_line_from_po_line(line)
Expand Down

0 comments on commit a441e89

Please sign in to comment.