Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] sale_stock: cancel sale order in multistep delivery
In case the warehouse is set in 2 or 3 steps delivery, validating the first picking forbid any sales order cancellation. This commit allows this flow by cancelling only active picking when cancelling a sale order. closes #68315 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
- Loading branch information
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amoyaux this is provoking a side effect: deliveries with only one step that has been validated, allows the sales order to be cancelled, and be deleted after that, removing as well the link sale <-> picking and leaving dangling pickings, which is a problem in several of our customers. Isn't there any other solution?
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza Hello. You get a message on the picking anyway. If you still need to block your flow I would suggest removing the button from the sale order view in case of one of the picking is done
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering, William. Yeah, we've got always that option, but changing the behavior in the middle of the version cycle seems awkward and has produced problems on the instances where they were relying on the block that this provoked previously. Now some users have removed sales orders that have been delivered, and there are dangling pickings without SO.
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Whenrow are you going to do such button change or restore the restriction? I think it's important to preserve the consistency.
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification really messed up everything big time. @pedrobaeza's statement is correct. @Whenrow
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We developed this module for preserving the behavior: https://odoo-community.org/shop/sale-stock-cancel-restriction-10003#attr=16959
abc9ee8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you brother!