Skip to content

Commit

Permalink
[FIX] hr_*: access rights issues when changing employee's user
Browse files Browse the repository at this point in the history
- When changing the user of a `hr.employee` record, access rights errors
  could be triggered.

  Those errors are triggered when a record (for example a leave) is
  linked to this employee and the current user has limited write
  accesses by record rules on this record.

closes #31032
  • Loading branch information
tbe-odoo committed Feb 12, 2019
1 parent 0191b65 commit bed3b4a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Expand Up @@ -10,7 +10,7 @@ class GamificationBadgeUserWizard(models.TransientModel):

employee_id = fields.Many2one('hr.employee', string='Employee', required=True)
user_id = fields.Many2one('res.users', string='User',
related='employee_id.user_id', store=True, readonly=True)
related='employee_id.user_id', store=True, readonly=True, compute_sudo=True)

# TODO 12.0/master remove this hack by changing the model
@api.model
Expand Down
2 changes: 1 addition & 1 deletion addons/hr_holidays/models/hr_holidays.py
Expand Up @@ -174,7 +174,7 @@ def _default_employee(self):
payslip_status = fields.Boolean('Reported in last payslips',
help='Green this button when the leave has been taken into account in the payslip.')
report_note = fields.Text('HR Comments')
user_id = fields.Many2one('res.users', string='User', related='employee_id.user_id', related_sudo=True, store=True, default=lambda self: self.env.uid, readonly=True)
user_id = fields.Many2one('res.users', string='User', related='employee_id.user_id', related_sudo=True, compute_sudo=True, store=True, default=lambda self: self.env.uid, readonly=True)
date_from = fields.Datetime('Start Date', readonly=True, index=True, copy=False,
states={'draft': [('readonly', False)], 'confirm': [('readonly', False)]})
date_to = fields.Datetime('End Date', readonly=True, copy=False,
Expand Down
2 changes: 1 addition & 1 deletion addons/hr_timesheet_sheet/models/hr_timesheet_sheet.py
Expand Up @@ -46,7 +46,7 @@ def _default_employee(self):

name = fields.Char(string="Note", states={'confirm': [('readonly', True)], 'done': [('readonly', True)]})
employee_id = fields.Many2one('hr.employee', string='Employee', default=_default_employee, required=True)
user_id = fields.Many2one('res.users', related='employee_id.user_id', string='User', store=True, readonly=True)
user_id = fields.Many2one('res.users', related='employee_id.user_id', string='User', store=True, readonly=True, compute_sudo=True)
date_from = fields.Date(string='Date From', default=_default_date_from, required=True,
index=True, readonly=True, states={'new': [('readonly', False)]})
date_to = fields.Date(string='Date To', default=_default_date_to, required=True,
Expand Down

0 comments on commit bed3b4a

Please sign in to comment.