Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_*: access rights issues when changing employee's user #31032

Closed

Conversation

tbe-odoo
Copy link
Contributor

  • When changing the user of a hr.employee record, access rights errors
    could be triggered.

    Those errors are triggered when a record (for example a leave) is
    linked to this employee and the current user has limited write
    accesses by record rules on this record.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

- When changing the user of a `hr.employee` record, access rights errors
  could be triggered.

  Those errors are triggered when a record (for example a leave) is
  linked to this employee and the current user has limited write
  accesses by record rules on this record.
@tbe-odoo tbe-odoo requested a review from KangOl February 12, 2019 15:52
@C3POdoo C3POdoo added the RD research & development, internal work label Feb 12, 2019
@KangOl
Copy link
Contributor

KangOl commented Feb 12, 2019

@robodoo r+

@tbe-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Feb 21, 2019

I'm sorry, @tbe-odoo. This PR is already reviewed, reviewing it again is useless.

@tbe-odoo
Copy link
Contributor Author

@robodoo retry

@robodoo
Copy link
Contributor

robodoo commented Feb 21, 2019

I'm sorry, @tbe-odoo. Retry makes no sense when the PR is not in error.

@tbe-odoo
Copy link
Contributor Author

@robodoo reset

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses merging 👷 and removed merging 👷 labels Feb 21, 2019
@robodoo
Copy link
Contributor

robodoo commented Feb 21, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/456069)

@robodoo robodoo added error 🙅 and removed CI 🤖 Robodoo has seen passing statuses labels Feb 21, 2019
@KangOl
Copy link
Contributor

KangOl commented Feb 21, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Feb 21, 2019
robodoo pushed a commit that referenced this pull request Feb 21, 2019
- When changing the user of a `hr.employee` record, access rights errors
  could be triggered.

  Those errors are triggered when a record (for example a leave) is
  linked to this employee and the current user has limited write
  accesses by record rules on this record.

closes #31032
@robodoo
Copy link
Contributor

robodoo commented Feb 21, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 21, 2019
remihb pushed a commit to osiell/OCB that referenced this pull request Mar 28, 2019
- When changing the user of a `hr.employee` record, access rights errors
  could be triggered.

  Those errors are triggered when a record (for example a leave) is
  linked to this employee and the current user has limited write
  accesses by record rules on this record.

closes odoo#31032
@fw-bot fw-bot deleted the 10.0-fix-employee-user-id-related-tbe branch October 19, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants