Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MERGE/FIX] web_tour,*: remove step delay in tests
For historical reasons, the tour manager executed each step of tour in a setTimeout (10ms). When a step could be executed (i.e. when its trigger selector has a match in the DOM), the element matching its trigger was saved as a jQuery element (the $anchor), and in the setTimeout, the action (e.g. click) was performed on that element. However, it could happen that, after the delay, the $anchor was no longer in the DOM, either because 1) the tip selector had no match anymore, meaning that the element had been removed from the DOM meanwhile 2) the tip selector still had a match in the DOM, but that element had been rerendered meanwhile Case 2) occured sometimes when the main_flow_tour was executed in community, when trying to open a Manufacturing Order after having reloaded the Manufacturing Order list view (because the row of the order to open that was saved as $anchor was the one of the list before the reload, and that list was re-rendered during the delay). This rev. removes the default delay of 10ms, but the feature is kept such that one can still manually run a tour slowly (e.g. to debug or to make a demo). It also adapts some tours that didn't pass anymore without the delay, and it fixes a bug in the kanban view that has been spotted thanks to the delay removal. closes #30106
- Loading branch information
Showing
8 changed files
with
176 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters