[FIX] barcode: set the max_time_between_keys_in_ms to 100 by default #101128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of max_time_between_keys_in_ms in barcode is 55 ms. The default value of 55 ms is too low and creates an issue for RFID readers. The default value of max_time_between_keys_in_ms is increased to 100 ms. task-2996072
|
|
|
@odoo/rd-security could you review this PR please? Thanks |
mart-e
reviewed
Sep 27, 2022
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 27, 2022
The default value of max_time_between_keys_in_ms in barcode is 55 ms. The default value of 55 ms is too low and creates an issue for RFID readers. The default value of max_time_between_keys_in_ms is increased to 100 ms. task-2996072 closes #101128 Signed-off-by: Kevin Baptiste <kba@odoo.com>
damn 🤦♂️ I thought the ci/security was red... my bad :-D |
This was referenced Sep 27, 2022
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Jan 11, 2023
The default value of max_time_between_keys_in_ms in barcode is 55 ms. The default value of 55 ms is too low and creates an issue for RFID readers. The default value of max_time_between_keys_in_ms is increased to 100 ms. task-2996072 closes odoo/odoo#101128 Signed-off-by: Kevin Baptiste <kba@odoo.com>
zamberjo
pushed a commit
to aurestic/OpenUpgrade
that referenced
this pull request
Mar 1, 2023
The default value of max_time_between_keys_in_ms in barcode is 55 ms. The default value of 55 ms is too low and creates an issue for RFID readers. The default value of max_time_between_keys_in_ms is increased to 100 ms. task-2996072 closes odoo/odoo#101128 Signed-off-by: Kevin Baptiste <kba@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of max_time_between_keys_in_ms in barcode is 55 ms. The default value of 55 ms is too low and creates an issue for RFID readers.
The default value of max_time_between_keys_in_ms is increased to 100 ms.
task-2996072
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr