[FW][FIX] stock: remove incoming warehouse address from delivery slip #123594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@clesgow @Whenrow cherrypicking of pull request #123281 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
forwardport
Whenrow
force-pushed
the
saas-16.1-15.0-fix-delivery-slip-warehouse-quwo-0J6U-fw
branch
from
58d9dd4
to
7f25083
Compare
|
robodoo r+ |
Steps to reproduce: - Configuration -> Settings -> Activate multi-locations. - Configuration -> Warehouses -> Three-step delivery. - Generate a three-step delivery (like through a sale order). - Select either PICK or PACK pickings. - Print the delivery slip. - There is a "warehouse address" field with the customer's adress in it. It makes little sense to display the current warehouse for internal transfers, as they keep being in the same warehouse after all. This doesn't impact inter-warehouse transit as in this case, an outgoing picking is done from one warehouse to the transit location and an incoming picking is done from the transit location to the other warehouse. In both cases the addresses are correctly displayed and didn't use this 'warehouse address'. opw-3335185 X-original-commit: 1449082
Whenrow
force-pushed
the
saas-16.1-15.0-fix-delivery-slip-warehouse-quwo-0J6U-fw
branch
from
7f25083
to
e93e39b
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 5, 2023
Steps to reproduce: - Configuration -> Settings -> Activate multi-locations. - Configuration -> Warehouses -> Three-step delivery. - Generate a three-step delivery (like through a sale order). - Select either PICK or PACK pickings. - Print the delivery slip. - There is a "warehouse address" field with the customer's adress in it. It makes little sense to display the current warehouse for internal transfers, as they keep being in the same warehouse after all. This doesn't impact inter-warehouse transit as in this case, an outgoing picking is done from one warehouse to the transit location and an incoming picking is done from the transit location to the other warehouse. In both cases the addresses are correctly displayed and didn't use this 'warehouse address'. opw-3335185 closes #123594 X-original-commit: 1449082 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
fw-bot
deleted the
saas-16.1-15.0-fix-delivery-slip-warehouse-quwo-0J6U-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
It makes little sense to display the current warehouse for internal transfers, as they keep being in the same warehouse after all. This doesn't impact inter-warehouse transit as in this case, an outgoing picking is done from one warehouse to the transit location and an incoming picking is done from the transit location to the other warehouse.
In both cases the addresses are correctly displayed and didn't use this 'warehouse address'.
opw-3335185
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #123509
Forward-Port-Of: #123281