-
Notifications
You must be signed in to change notification settings - Fork 23.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] base,account: manage subsidiary companies #125642
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-andre
force-pushed
the
master-subsidiaries-wan
branch
from
June 19, 2023 14:32
5edc777
to
dd12df5
Compare
william-andre
force-pushed
the
master-subsidiaries-wan
branch
17 times, most recently
from
June 26, 2023 18:04
af738d3
to
d079567
Compare
william-andre
force-pushed
the
master-subsidiaries-wan
branch
from
June 27, 2023 09:39
d079567
to
9e228b6
Compare
william-andre
changed the title
[WIP] base,account: manage subsidiary companies
[IMP] base,account: manage subsidiary companies
Jun 28, 2023
xmo-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Aug 29, 2023
Account codes are very commonly searched by prefix. This field used to be implicitly indexed thanks to a unique constraint on `(code, company_id)`, however the constraint was removed in odoo#125642 rather than converted to an index. For the issue at hand `code` has a much higher discrimination power than `company_id`, however it might make sense to also index `company_id`, or to add compound indexes for `code, company_id` and / or `company_id, code` for other work loads.
robodoo
pushed a commit
that referenced
this pull request
Aug 29, 2023
Account codes are very commonly searched by prefix. This field used to be implicitly indexed thanks to a unique constraint on `(code, company_id)`, however the constraint was removed in #125642 rather than converted to an index. For the issue at hand `code` has a much higher discrimination power than `company_id`, however it might make sense to also index `company_id`, or to add compound indexes for `code, company_id` and / or `company_id, code` for other work loads. Part-of: #133436
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Aug 29, 2023
Account codes are very commonly searched by prefix. This field used to be implicitly indexed thanks to a unique constraint on `(code, company_id)`, however the constraint was removed in odoo#125642 rather than converted to an index. For the issue at hand `code` has a much higher discrimination power than `company_id`, however it might make sense to also index `company_id`, or to add compound indexes for `code, company_id` and / or `company_id, code` for other work loads. X-original-commit: 45c5799
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Account codes are very commonly searched by prefix. This field used to be implicitly indexed thanks to a unique constraint on `(code, company_id)`, however the constraint was removed in #125642 rather than converted to an index. For the issue at hand `code` has a much higher discrimination power than `company_id`, however it might make sense to also index `company_id`, or to add compound indexes for `code, company_id` and / or `company_id, code` for other work loads. X-original-commit: 45c5799 Part-of: #133530
lordkrandel
added a commit
to odoo-dev/odoo
that referenced
this pull request
Oct 10, 2023
Fixed the bug introduced by the change in domain for subsidiary companies on the partners search. ref: odoo#125642 "Domains to normalize must have a 'domain' form: a list or tuple of domain components" Ticket link: https://www.odoo.com/web#model=project.task&id=3536387 opw-3536387
robodoo
pushed a commit
that referenced
this pull request
Oct 10, 2023
Fixed the bug introduced by the change in domain for subsidiary companies on the partners search. ref: #125642 "Domains to normalize must have a 'domain' form: a list or tuple of domain components" Ticket link: https://www.odoo.com/web#model=project.task&id=3536387 opw-3536387 closes #138065 Signed-off-by: Josse Colpaert <jco@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sharing records between company
These records can be read and used in children companies.
This can be used to
country
task-3371677