Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] base,account: manage subsidiary companies #125642

Closed
wants to merge 6 commits into from

Conversation

fpodoo
Copy link
Contributor

@fpodoo fpodoo commented Jun 19, 2023

Allow sharing records between company

  • accounts
  • taxes
  • fiscal positions

These records can be read and used in children companies.

This can be used to

  • have different branding for different businesses
  • allow more complex security rules
  • consolidate branches differently
  • manage different tax reports with different tax ids in the same
    country

task-3371677

@robodoo
Copy link
Contributor

robodoo commented Jun 19, 2023

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Jun 19, 2023
@william-andre william-andre force-pushed the master-subsidiaries-wan branch 17 times, most recently from af738d3 to d079567 Compare June 26, 2023 18:04
@william-andre william-andre marked this pull request as ready for review June 27, 2023 09:01
@william-andre william-andre changed the title [WIP] base,account: manage subsidiary companies [IMP] base,account: manage subsidiary companies Jun 28, 2023
@C3POdoo C3POdoo requested review from a team June 28, 2023 09:45
@fw-bot fw-bot deleted the master-subsidiaries-wan branch August 3, 2023 11:46
xmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Aug 29, 2023
Account codes are very commonly searched by prefix. This field used to
be implicitly indexed thanks to a unique constraint on `(code,
company_id)`, however the constraint was removed in odoo#125642 rather
than converted to an index.

For the issue at hand `code` has a much higher discrimination power
than `company_id`, however it might make sense to also index
`company_id`, or to add compound indexes for `code, company_id` and /
or `company_id, code` for other work loads.
robodoo pushed a commit that referenced this pull request Aug 29, 2023
Account codes are very commonly searched by prefix. This field used to
be implicitly indexed thanks to a unique constraint on `(code,
company_id)`, however the constraint was removed in #125642 rather
than converted to an index.

For the issue at hand `code` has a much higher discrimination power
than `company_id`, however it might make sense to also index
`company_id`, or to add compound indexes for `code, company_id` and /
or `company_id, code` for other work loads.

Part-of: #133436
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Aug 29, 2023
Account codes are very commonly searched by prefix. This field used to
be implicitly indexed thanks to a unique constraint on `(code,
company_id)`, however the constraint was removed in odoo#125642 rather
than converted to an index.

For the issue at hand `code` has a much higher discrimination power
than `company_id`, however it might make sense to also index
`company_id`, or to add compound indexes for `code, company_id` and /
or `company_id, code` for other work loads.

X-original-commit: 45c5799
robodoo pushed a commit that referenced this pull request Sep 4, 2023
Account codes are very commonly searched by prefix. This field used to
be implicitly indexed thanks to a unique constraint on `(code,
company_id)`, however the constraint was removed in #125642 rather
than converted to an index.

For the issue at hand `code` has a much higher discrimination power
than `company_id`, however it might make sense to also index
`company_id`, or to add compound indexes for `code, company_id` and /
or `company_id, code` for other work loads.

X-original-commit: 45c5799
Part-of: #133530
lordkrandel added a commit to odoo-dev/odoo that referenced this pull request Oct 10, 2023
Fixed the bug introduced by the change in domain
for subsidiary companies on the partners search.

ref: odoo#125642

"Domains to normalize must have a 'domain' form: a list or tuple of domain components"

Ticket link: https://www.odoo.com/web#model=project.task&id=3536387
opw-3536387
robodoo pushed a commit that referenced this pull request Oct 10, 2023
Fixed the bug introduced by the change in domain
for subsidiary companies on the partners search.

ref: #125642

"Domains to normalize must have a 'domain' form: a list or tuple of domain components"

Ticket link: https://www.odoo.com/web#model=project.task&id=3536387
opw-3536387

closes #138065

Signed-off-by: Josse Colpaert <jco@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.4 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants