[FIX] core: assure check_company and _check_company_auto makes sense #162128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
force-pushed
the
master-imp-company-checks
branch
13 times, most recently
from
897bce1
to
2f8125d
Compare
MiquelRForgeFlow
force-pushed
the
master-imp-company-checks
branch
from
2f8125d
to
2db828d
Compare
C3POdoo
requested review from
a team,
rco-odoo and
ryv-odoo
and removed request for
a team
|
@william-andre maybe you are interested, as you worked on #125642. |
|
Hi, if you don't like the checks, then an alternative maybe should be adding the fixes without the checks... Let at least the fixes go in. |
|
In the end, tis code is not in my ownership, the framework team is going to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based in old #46721. It was forgotten 😥
Enterprise PR: https://github.com/odoo/enterprise/pull/60882.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr