[8.0][FIX][web] Detect image MIME. #12918
Conversation
Try to detect the mimetype by binary content before falling back to default. This covers the same use case as odoo#12918, but using new tools in v9.
Odoo v8 lacks a MIME autodetect method, but backporting the most relevant parts from v9, we can make it detect the image type and serve the correct header, to allow some client-side manipulations to work fine.
yajo
force-pushed
the
8.0-web-fix_hardcoded_image_mime
branch
from
3551b99
to
65dcc7e
Compare
|
👍 without a doubt |
yajo
changed the title
|
👍 |
|
Hello, We do not wish to change the way the web client handles mimetype in 8.0. It is a very side effect-prone changes with a low ratio value/risk. (We had issues in the past changing this). We have changed quite a bit the way we handle binaries in 10.0. If there is still issues about it, feel free to adapt and resubmit. We will check it there. Regards |
|
Can you please point to the commit that changes the behavior to try, @mart-e ? |
|
You mean the difference in 10.0? The route |
|
OK, I'll check this new code. Thanks for the pointer. |
Description of the issue/feature this PR addresses:
We are creating a control to download an image, but the server is not telling the right MIME type in this controller.
Current behavior before PR:
When visiting a URL such as http://localhost/web/binary/image?model=res.users&id=1&field=image_small&t=1469603889889, the controller always says the image is
image/png, while sometimes it is JPG.Desired behavior after PR is merged:
The server can know if it is PNG, GIF or JPEG, and outputs the correct header.
Odoo v8 lacks a MIME autodetect method, but backporting the most relevant parts from v9, we can make it detect the image type and serve the correct header, to allow some client-side manipulations to work fine.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@Tecnativa @kutyel