Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master picking ref arm #137864

Closed
wants to merge 1 commit into from
Closed

Master picking ref arm #137864

wants to merge 1 commit into from

Conversation

amoyaux
Copy link
Contributor

@amoyaux amoyaux commented Oct 6, 2023

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Oct 6, 2023

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label Oct 6, 2023
@amoyaux amoyaux requested a review from adwid October 6, 2023 13:06
@Whenrow Whenrow force-pushed the master-picking-ref-arm branch 2 times, most recently from e5d8f09 to ccaf47d Compare October 19, 2023 15:33
@amoyaux amoyaux force-pushed the master-picking-ref-arm branch 7 times, most recently from dafa326 to fa3ceee Compare October 24, 2023 07:58
@amoyaux amoyaux marked this pull request as ready for review October 24, 2023 09:47
@C3POdoo C3POdoo requested review from a team, lordkrandel, rhe-odoo, Iucapad and juliusc2066 and removed request for a team October 24, 2023 09:49
ticodoo added a commit to odoo-dev/odoo that referenced this pull request Jan 4, 2024
@ticodoo
[FIX] stock: ensure reception report always uses quantity field
d7a83b9 
Following quantitypocalypse (odoo#137864), a couple of
`reserved_uom_qty` and `reserved_qty` references were left over. This
was partially due to no tests for these tricky parts of the code,
therefore we both fix these references to use the newer
`quantity`/`quantity_product_uom` fields and add/update tests to ensure
we avoid breaking these 2 use cases again.

Also discovered during this fix, the remaining assigned qtys when
unassigning done incoming moves from already reserved outgoing moves
(i.e. the "1. batch reserved + individual picking unreserved" use case
in the code comments) was NOT being calculated correctly. This also
fixes that + adds a test for it.

X-original-commit: 7e6b875
robodoo pushed a commit that referenced this pull request Jan 5, 2024
@ticodoo
[FIX] stock: ensure reception report always uses quantity field
d970b21 
Following quantitypocalypse (#137864), a couple of
`reserved_uom_qty` and `reserved_qty` references were left over. This
was partially due to no tests for these tricky parts of the code,
therefore we both fix these references to use the newer
`quantity`/`quantity_product_uom` fields and add/update tests to ensure
we avoid breaking these 2 use cases again.

Also discovered during this fix, the remaining assigned qtys when
unassigning done incoming moves from already reserved outgoing moves
(i.e. the "1. batch reserved + individual picking unreserved" use case
in the code comments) was NOT being calculated correctly. This also
fixes that + adds a test for it.

closes #148004

X-original-commit: 7e6b875
Related: odoo/enterprise#53621
Related: odoo/upgrade#5490
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
@lase-odoo lase-odoo mentioned this pull request Feb 19, 2024
Closed
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Mar 14, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
318e3cc 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Mar 14, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
854340b 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
@luisg123v luisg123v mentioned this pull request Mar 20, 2024
Merged
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 1, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
9b6ceae 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 1, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
7b732e2 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 1, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
b367eb2 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 3, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
75f4978 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
e3bb94f 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord
[MIG] stock_by_warehouse: Migration to 17.0
3a9ad7b 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord
[MIG] default_warehouse_from_sale_team: Migration to 17.0
7c68e56 
- Adapt the use of name_get as part of [1].
- Change qty_done to quantity and picked = True as part of [2].

[1] odoo/odoo#122085
[2] odoo/odoo#137864
luisg123v pushed a commit to Vauxoo/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord @luisg123v
[MIG] stock_by_warehouse: Migration to 17.0
d445333 
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [1].
- Remove owl="1" from OWL templates, as it's not needed anymore as all
  of them are OWL now as part of [2].
- Change qty_done to quantity and picked = True as part of [3].
- Adapt use of read_group to _read_group as part of [4].

[1] odoo/odoo#104741
[2] odoo/odoo#130467
[3] odoo/odoo#137864
[4] odoo/odoo#110737
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord
[MIG] default_warehouse_from_sale_team: Migration to 17.0
7d9cf0d 
- Adapt the use of name_get as part of [1].
- Change qty_done to quantity and picked = True as part of [2].

[1] odoo/odoo#122085
[2] odoo/odoo#137864
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord
[MIG] default_warehouse_from_sale_team: Migration to 17.0
d2076bb 
- Adapt the use of name_get as part of [1].
- Change qty_done to quantity and picked = True as part of [2].

[1] odoo/odoo#122085
[2] odoo/odoo#137864
@luisg123v luisg123v mentioned this pull request Apr 4, 2024
Merged
luisg123v pushed a commit to Vauxoo/addons-vauxoo that referenced this pull request Apr 4, 2024
@xmglord @luisg123v
[MIG] default_warehouse_from_sale_team: Migration to 17.0
3805376 
- Adapt the use of name_get as part of [1].
- Change qty_done to quantity and picked = True as part of [2].

[1] odoo/odoo#122085
[2] odoo/odoo#137864
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 25, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
4bc5187 
- Update fields names and models names with the respective file name.
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].

[1] odoo/odoo#137864
[2] odoo/odoo#104741
desdelinux pushed a commit to vauxoo-dev/addons-vauxoo that referenced this pull request Apr 26, 2024
@xmglord @desdelinux
[MIG] stock_manual_transfer: Migration to 17.0
fe3a4c3 
- Update fields names and models names with the respective file name.
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].

[1] odoo/odoo#137864
[2] odoo/odoo#104741
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request May 3, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
a2f1aea 
- Update demo data and test fields names
- Update models names and their respective file name.
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].

[1] odoo/odoo#137864
[2] odoo/odoo#104741
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request May 3, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
8aa8cf9 
- Update demo data and test fields names.
- Update models names and their respective file name.
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].
- Fix tests.

[1] odoo/odoo#137864
[2] odoo/odoo#104741
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request May 3, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
742c071 
- Update demo data and test fields names.
- Update models names and their respective file name.
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].
- Fix tests.

[1] odoo/odoo#137864
[2] odoo/odoo#104741
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request May 22, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
8259132 
- Update demo data and test fields names.
- Update models names and their respective file name.
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].
- Fix tests.

[1] odoo/odoo#137864
[2] odoo/odoo#104741
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request May 22, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
f1420e4 
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].
- Fix tests.

[1] odoo/odoo#137864
[2] odoo/odoo#104741
xmglord added a commit to vauxoo-dev/addons-vauxoo that referenced this pull request May 23, 2024
@xmglord
[MIG] stock_manual_transfer: Migration to 17.0
65e3909 
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].
- Fix tests.

[1] odoo/odoo#137864
[2] odoo/odoo#104741
luisg123v pushed a commit to Vauxoo/addons-vauxoo that referenced this pull request May 24, 2024
@xmglord @luisg123v
[MIG] stock_manual_transfer: Migration to 17.0
a407401 
- Update use of quantity as part of [1].
- Simplify the way to define modifiers as states, required, readonly,
  invisible and column_invisible as part of [2].
- Fix tests.

[1] odoo/odoo#137864
[2] odoo/odoo#104741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwid adwid Awaiting requested review from adwid

@lordkrandel lordkrandel Awaiting requested review from lordkrandel lordkrandel was automatically assigned from odoo/rd-accounting

@rhe-odoo rhe-odoo Awaiting requested review from rhe-odoo rhe-odoo was automatically assigned from odoo/pos

@Iucapad Iucapad Awaiting requested review from Iucapad Iucapad was automatically assigned from odoo/rd-framework-js

@juliusc2066 juliusc2066 Awaiting requested review from juliusc2066 juliusc2066 was automatically assigned from odoo/rd-framework-js

@rco-odoo rco-odoo Awaiting requested review from rco-odoo rco-odoo was automatically assigned from odoo/rd-framework-py

@HydrionBurst HydrionBurst Awaiting requested review from HydrionBurst HydrionBurst was automatically assigned from odoo/rd-framework-py

Assignees
No one assigned
Labels
16.5 RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amoyaux @robodoo @C3POdoo