[MERGE][REF] web: remove qweb #130467
Closed
[MERGE][REF] web: remove qweb #130467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpp-odoo
force-pushed
the
master-remove_qweb_render-jpp
branch
2 times, most recently
from
af83db3
to
e18cb92
Compare
jpp-odoo
force-pushed
the
master-remove_qweb_render-jpp
branch
26 times, most recently
from
1b1f893
to
7e5b9a4
Compare
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 29, 2024
Since the PR [1] changed the rendering engine of qweb, the default "selected" value set on selects field on the form snippet were lost once the page is saved. This commit builds upon the changes made in [this commit] by reinstating the default "selected" value. Steps to replicate: - Go to Website -> Edit. - Drop a Form snippet onto the page. - Click on the 'Company' field. - In Field > Type, opt for "Selection". - Choose option 3 from the options list to establish it as the default. - Save the modifications. Issue: The expected default value for the selection field is not retained after saving. [1]: odoo#130467 [this commit]: odoo@b42e9cc task-3767819 X-original-commit: dd50481
robodoo
pushed a commit
that referenced
this pull request
Mar 1, 2024
Since the PR [1] changed the rendering engine of qweb, the default "selected" value set on selects field on the form snippet were lost once the page is saved. This commit builds upon the changes made in [this commit] by reinstating the default "selected" value. Steps to replicate: - Go to Website -> Edit. - Drop a Form snippet onto the page. - Click on the 'Company' field. - In Field > Type, opt for "Selection". - Choose option 3 from the options list to establish it as the default. - Save the modifications. Issue: The expected default value for the selection field is not retained after saving. [1]: #130467 [this commit]: b42e9cc task-3767819 closes #155977 X-original-commit: dd50481 Signed-off-by: Romain Derie (rde) <rde@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 1, 2024
Since the PR [1] changed the rendering engine of qweb, the default "selected" value set on selects field on the form snippet were lost once the page is saved. This commit builds upon the changes made in [this commit] by reinstating the default "selected" value. Steps to replicate: - Go to Website -> Edit. - Drop a Form snippet onto the page. - Click on the 'Company' field. - In Field > Type, opt for "Selection". - Choose option 3 from the options list to establish it as the default. - Save the modifications. Issue: The expected default value for the selection field is not retained after saving. [1]: #130467 [this commit]: b42e9cc task-3767819 closes #155988 X-original-commit: dd50481 Signed-off-by: Romain Derie (rde) <rde@odoo.com>
rdeodoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 4, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: b42e9cc [2]: dd50481 [3]: #130467 opw-3755078 closes #156666 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 6, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 X-original-commit: d683947
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 6, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 X-original-commit: d683947
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: b42e9cc [2]: dd50481 [3]: #130467 opw-3755078 closes #156818 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: b42e9cc [2]: dd50481 [3]: #130467 opw-3755078 closes #156804 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
MohammedBasioni
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 8, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 closes odoo#156818 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
thle-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 8, 2024
Since the PR [1] changed the rendering engine of qweb, the default "selected" value set on selects field on the form snippet were lost once the page is saved. This commit builds upon the changes made in [this commit] by reinstating the default "selected" value. Steps to replicate: - Go to Website -> Edit. - Drop a Form snippet onto the page. - Click on the 'Company' field. - In Field > Type, opt for "Selection". - Choose option 3 from the options list to establish it as the default. - Save the modifications. Issue: The expected default value for the selection field is not retained after saving. [1]: odoo#130467 [this commit]: odoo@b42e9cc task-3767819 closes odoo#155988 X-original-commit: dd50481 Signed-off-by: Romain Derie (rde) <rde@odoo.com>
thle-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 8, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 closes odoo#156818 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Mar 14, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. [1] odoo/odoo#104741 [2] odoo/odoo#130467
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Mar 14, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. [1] odoo/odoo#104741 [2] odoo/odoo#130467
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Mar 14, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Mar 14, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864
xlu-odoo
pushed a commit
to odoo-dev/design-themes
that referenced
this pull request
Mar 14, 2024
As all the templates are now imported in the owl app, there is not need anymore to specify the owl="1" attribute in the templates. Part of task~3443861 closes odoo#686 Related: odoo/enterprise#45020 Related: odoo/odoo#130467 Signed-off-by: Samuel Degueldre (sad) <sad@odoo.com>
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Apr 1, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Apr 1, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Apr 1, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Apr 3, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Apr 4, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
xmglord
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Apr 4, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
luisg123v
pushed a commit
to Vauxoo/addons-vauxoo
that referenced
this pull request
Apr 4, 2024
- Simplify the way to define modifiers as states, required, readonly, invisible and column_invisible as part of [1]. - Remove owl="1" from OWL templates, as it's not needed anymore as all of them are OWL now as part of [2]. - Change qty_done to quantity and picked = True as part of [3]. - Adapt use of read_group to _read_group as part of [4]. [1] odoo/odoo#104741 [2] odoo/odoo#130467 [3] odoo/odoo#137864 [4] odoo/odoo#110737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR, is to remove qweb and use owl to render all the templates.
task~3443861