Master product clean all views kme #14541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atp-odoo
reviewed
Dec 1, 2016
| <record id="product_template_view_default_analytic_button" model="ir.ui.view"> | ||
| <field name="name">product.template.inherit.rules_count</field> | ||
| <field name="model">product.template</field> | ||
| <field name="inherit_id" ref="product.product_template_only_form_view"/> | ||
| <field name="inherit_id" ref="product.product_template_form_view"/> | ||
| <field name="arch" type="xml"> | ||
| <button name="toggle_active" position="before"> | ||
| <button name= "action_view_rules" class="oe_stat_button" type="object" |
There was a problem hiding this comment.
if you tried this same for variant then you got traceback because "action_view_rules" method defined only in template not variant..
so you have to convert button to type action and set domain and context here .. .and remove this function "action_view_rules".
atp-odoo
reviewed
Dec 1, 2016
| @@ -259,54 +259,6 @@ | |||
| </field> | |||
| </record> | |||
|
|
|||
| <record id="product_product_expense_form_view" model="ir.ui.view"> | |||
There was a problem hiding this comment.
i think we have to keep this view. because it's not inherited .. if you remove it then default variant view display which contain some other ununsed field which is not usefule for expense may be..
atp-odoo
reviewed
Dec 1, 2016
| @@ -41,7 +41,7 @@ | |||
| <record id="product_template_form_view_bom_button" model="ir.ui.view"> | |||
| <field name="name">product.template.procurement</field> | |||
| <field name="model">product.template</field> | |||
| <field name="inherit_id" ref="product.product_template_only_form_view"/> | |||
| <field name="inherit_id" ref="product.product_template_form_view"/> | |||
| <field name="groups_id" eval="[(4, ref('mrp.group_mrp_user'))]"/> | |||
| <field name="arch" type="xml"> | |||
| <button name="toggle_active" position="before"> | |||
There was a problem hiding this comment.
not working for product. check here for template it's open action and in variant it's define function which call different action with domain..
atp-odoo
reviewed
Dec 1, 2016
| @@ -596,18 +596,19 @@ | |||
| <field name="inherit_id" ref="account.product_template_form_view"/> | |||
| <field name="arch" type="xml"> | |||
| <field name="property_account_expense_id" position="replace" > | |||
| <field name="property_account_expense_id" domain="[('deprecated','=',False)]" attrs="{'readonly': [('purchase_ok', '=', 0)]}" groups="account.group_account_user"/> | |||
| <field name="property_account_expense_id" domain="[('deprecated','=',False)]" attrs="{'readonly': [('purchase_ok', '=', 0)]}" groups="account.group_account_user"/> | |||
There was a problem hiding this comment.
remove this change.no need to do here for this task..
atp-odoo
reviewed
Dec 1, 2016
| </field> | ||
| <field name='supplier_taxes_id' position="replace" > | ||
| <field name="supplier_taxes_id" colspan="2" widget="many2many_tags" attrs="{'readonly':[('purchase_ok','=',0)]}"/> | ||
| <field name="supplier_taxes_id" colspan="2" widget="many2many_tags" attrs="{'readonly':[('purchase_ok','=',0)]}"/> | ||
| <field name="property_account_creditor_price_difference" domain="[('deprecated','=',False)]" attrs="{'readonly':[('purchase_ok', '=', 0)]}" /> |
There was a problem hiding this comment.
remove this change.no need to do here for this task..
kme-odoo
force-pushed
the
master-product_clean_all_views-kme
branch
from
5213b19
to
16200f0
Compare
kme-odoo
force-pushed
the
master-product_clean_all_views-kme
branch
13 times, most recently
from
72f82a2
to
8c64197
Compare
atp-odoo
force-pushed
the
master-product_clean_all_views-kme
branch
from
8c64197
to
21d046e
Compare
kme-odoo
force-pushed
the
master-product_clean_all_views-kme
branch
3 times, most recently
from
3887ec9
to
3b22365
Compare
…y cleaning the useless code
…aning the useless code
… cleaning the useless code
…y cleaning the useless code
kme-odoo
force-pushed
the
master-product_clean_all_views-kme
branch
from
3b22365
to
be68eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task : https://www.odoo.com/web?#id=28196&view_type=form&model=project.task&action=327&menu_id=4720
Pad : https://pad.odoo.com/p/r.633aa76315fd60bedbe5e045291a2b90
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr