Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_sale: simplify product ribbons #145562

Closed

Conversation

vchu-odoo
Copy link
Contributor

@vchu-odoo vchu-odoo commented Dec 8, 2023

To ease a user experience a product.ribbon model and its
configuration were simplified. HTML customisation of ribbons was
removed and replaced with a position selection, color pickers and
a name as a text field type.

task-3392068

See also:

@robodoo
Copy link
Contributor

robodoo commented Dec 8, 2023

@C3POdoo C3POdoo added the RD research & development, internal work label Dec 8, 2023
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch 2 times, most recently from 8ebdb51 to 31d167a Compare December 12, 2023 12:40
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch from 31d167a to 2317edd Compare January 26, 2024 09:08
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch 2 times, most recently from a8e7b92 to 6282155 Compare February 7, 2024 12:23
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch 2 times, most recently from 277746f to 077bae8 Compare February 20, 2024 12:44
@vchu-odoo vchu-odoo changed the title [IMP] website_sale: enable product ribbons [IMP] website_sale: simplify product ribbons Feb 20, 2024
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch from 077bae8 to 90176ab Compare February 20, 2024 12:49
Copy link
Contributor

@chevalierv chevalierv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vchu-odoo

Good job on this task 😃 LGTM 👍

addons/website_sale/views/templates.xml Outdated Show resolved Hide resolved
addons/website_sale/views/templates.xml Outdated Show resolved Hide resolved
addons/website_sale/views/product_views.xml Outdated Show resolved Hide resolved
addons/website_sale/views/snippets/snippets.xml Outdated Show resolved Hide resolved
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch 5 times, most recently from 77ff4c6 to 006316f Compare March 21, 2024 08:00
@vchu-odoo vchu-odoo force-pushed the master-improve-product-ribbons-vchu branch from 006316f to 43efa73 Compare March 25, 2024 08:04
@vchu-odoo vchu-odoo marked this pull request as ready for review March 25, 2024 15:21
@C3POdoo C3POdoo requested a review from a team March 25, 2024 15:25
@AntoineVDV AntoineVDV force-pushed the master-improve-product-ribbons-vchu branch 2 times, most recently from f70da01 to b196831 Compare March 28, 2024 15:55
To ease a user experience a product.ribbon model and its
configuration were simplified. HTML customisation of ribbons was
removed and replaced with a position selection, color pickers and
a name as a text field type.

task-3392068
@AntoineVDV AntoineVDV force-pushed the master-improve-product-ribbons-vchu branch from b196831 to 194508d Compare March 28, 2024 15:55
Copy link
Contributor

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 💯

@robodoo r+

@AntoineVDV
Copy link
Contributor

@robodoo override=ci/security
Reason: .empty().append(: variable renaming
Link to ci/security build (master): https://runbot.odoo.com/runbot/batch/1395080/build/60337560

robodoo pushed a commit that referenced this pull request Mar 29, 2024
To ease a user experience a product.ribbon model and its
configuration were simplified. HTML customisation of ribbons was
removed and replaced with a position selection, color pickers and
a name as a text field type.

task-3392068

closes #145562

Related: odoo/upgrade#5843
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo closed this Mar 29, 2024
@robodoo robodoo added the 17.3 label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants