[FW][FIX] website_sale: prevent typeerror when ribbon background color is False

[fw-bot]

When the user creates a new ribbon without a background color,
a traceback will appear.

Steps to reproduce the error:

• Install "website_sale"
• Go to Website > eCommerce > Products
• Pick a product > Sales > Create a new ribbon without a background color
• Save & Close

Traceback:

TypeError: argument of type 'bool' is not iterable
  File "odoo/http.py", line 2251, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1826, in _serve_db
    return self._transactioning(_serve_ir_http, readonly=ro)
  File "odoo/http.py", line 1847, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1824, in _serve_ir_http
    return self._serve_ir_http(rule, args)
  File "odoo/http.py", line 1832, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2057, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 222, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 740, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 34, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 30, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 458, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
  File "addons/web/models/models.py", line 74, in web_save
    self = self.create(vals)
  File "<decorator-gen-471>", line 2, in create
  File "odoo/api.py", line 420, in _model_create_multi
    return create(self, [arg])
  File "addons/website_sale/models/product_ribbon.py", line 24, in create
    if 'bg_color' in vals and not '!important' in vals['bg_color']:

odoo/addons/website_sale/models/product_ribbon.py

Line 24 in 806a60d

if 'bg_color' in vals and not '!important' in vals['bg_color']:

Here, when the user creates a new ribbon without a background color,
"bg_color" will be False, so when it tries to check "vals['bg_color']".
It will lead to the above traceback.

sentry-5077714703

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #158561

[robodoo]

Pull request status dashboard.

[fw-bot]

@reka-odoo @AntoineVDV this PR targets master and is the last of the forward-port chain containing:

• [FW][FIX] website_sale: prevent typeerror when ribbon background color is False #158995
• [FW][FIX] website_sale: prevent typeerror when ribbon background color is False #158977
• [FW][FIX] website_sale: prevent typeerror when ribbon background color is False #158954

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[reka-odoo]

@fw-bot r+

[reka-odoo]

@fw-bot r+

[adwid]

@reka-odoo
Don't worry, the command has already been correctly received the first time you sent it
There is just a huge waiting queue on the merge page

See https://mergebot.odoo.com/runbot_merge

[robodoo]

@reka-odoo @AntoineVDV unable to stage: merge conflict

[AntoineVDV]

Superseded by #145562