Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: fix the test case related to the year #147813

Closed
wants to merge 1 commit into from

Conversation

ppr-odoo
Copy link
Contributor

@ppr-odoo ppr-odoo commented Jan 2, 2024

Before this commit, since we are no longer in 2023, the test failed because there is no longer 2021 in the filters dynamically added in the dropdown of the date filter. The reason is now we have the current year, the previous one, and the one before, that is, 2024, 2023, 2022.

Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).
@robodoo
Copy link
Contributor

robodoo commented Jan 2, 2024

@C3POdoo C3POdoo requested review from a team, FrancoisGe and juliusc2066 and removed request for a team January 2, 2024 10:17
@xavierbol
Copy link
Contributor

Coucou @odoo/rd-framework-js ,

Can we have a review for that fix when you have time? 🙂

Thanks in advance! 🙂

Happy New Year! 🥂 🥳

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 2, 2024
Copy link
Contributor

@alexkuhn alexkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexkuhn
Copy link
Contributor

alexkuhn commented Jan 2, 2024

Test "global filters and their display value are exported" also require same patchDate fix in 17.0.
I cherry-picked this commit for 17.0 and added a commit with similar fix: #147823

@alexkuhn
Copy link
Contributor

alexkuhn commented Jan 2, 2024

And similar issue in 15.0, I made a PR that targets this version: #147824

@robodoo
Copy link
Contributor

robodoo commented Jan 2, 2024

@ppr-odoo @alexkuhn staging failed: ci/l10n on 654ec3e422996366cdee8d8b3be178658f0caf11 (view more at https://runbot.odoo.com/runbot/build/55832251)

@d-fence
Copy link
Contributor

d-fence commented Jan 2, 2024

robodoo retry
the failing new year test was disabled

robodoo pushed a commit that referenced this pull request Jan 2, 2024
Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).

closes #147813

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
@robodoo robodoo closed this Jan 2, 2024
paimonchan pushed a commit to paimonchan/odoo that referenced this pull request Jan 10, 2024
Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).

closes odoo#147813

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
paimonchan pushed a commit to paimonchan/odoo that referenced this pull request Jan 11, 2024
Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).

closes odoo#147813

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
@fw-bot fw-bot deleted the 16.0-web-test-fix-ppr branch January 16, 2024 15:46
luanjubica pushed a commit to luanjubica/odoo-code that referenced this pull request Feb 14, 2024
Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).

closes odoo#147813

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants