Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: fix the test case related to the year #147899

Closed
wants to merge 1 commit into from

Conversation

emi-odoo
Copy link

@emi-odoo emi-odoo commented Jan 3, 2024

Before this commit, since we are no longer in 2023, the test failed because there is no longer 2021 in the filters dynamically added in the dropdown of the date filter. The reason is now we have the current year, the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023, to get the expected filters displayed (2023, 2022, 2021).

Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).
@robodoo
Copy link
Contributor

robodoo commented Jan 3, 2024

@emi-odoo
Copy link
Author

emi-odoo commented Jan 3, 2024

Backport of #147813

@aab-odoo
Copy link
Contributor

aab-odoo commented Jan 3, 2024

@fw-bot ignore

@fw-bot
Copy link
Contributor

fw-bot commented Jan 3, 2024

Forward-port disabled.

@aab-odoo
Copy link
Contributor

aab-odoo commented Jan 3, 2024

robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Jan 3, 2024

@aab-odoo you may want to rebuild or fix this PR as it has failed CI.

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 3, 2024
@C3POdoo C3POdoo requested review from a team, FrancoisGe and Iucapad and removed request for a team January 3, 2024 11:06
robodoo pushed a commit that referenced this pull request Jan 3, 2024
Before this commit, since we are no longer in 2023, the test failed
because there is no longer 2021 in the filters dynamically added in the
dropdown of the date filter. The reason is now we have the current year,
the previous one, and the one before, that is, 2024, 2023, 2022.

This commit adds a patchDate to be sure we will start the test in 2023,
to get the expected filters displayed (2023, 2022, 2021).

closes #147899

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
@robodoo robodoo closed this Jan 3, 2024
@fw-bot fw-bot deleted the 14.0-web-test-fix-emi branch January 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants