[IMP]mass_mailling:Disabaling the creation of mail if no email found. #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mep-odoo
force-pushed
the
master-mass-mailing-email-improvement-mep
branch
from
c81db6c
to
2d52a31
Compare
tde-banana-odoo
force-pushed
the
master-mass-mailing-email-improvement-mep
branch
from
2d52a31
to
cc8af5b
Compare
| @@ -66,4 +66,12 @@ def get_mail_values(self, res_ids): | |||
| 'notification': mass_mailing.reply_to_mode == 'thread', | |||
| 'auto_delete': not mass_mailing.keep_archives, | |||
| }) | |||
| if not (res[res_id].get('email_to') or res[res_id].get('recipient_ids')): | |||
There was a problem hiding this comment.
You should instead put the mail in state cancel like done before for blacklist and stuff like that. Avoid modifying res, and put correct values in it instead.
… state of mail to cancel for those who has not email to or not recipient ids
tde-banana-odoo
deleted the
master-mass-mailing-email-improvement-mep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Task : https://www.odoo.com/web#id=30428&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720
Pad : https://pad.odoo.com/p/r.049d4059ff5ef3363ca2b82905299864
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr