[FIX] Calendar: Improved recurrent event when dst happens #15202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
cd3eaef
to
145d4de
Compare
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
145d4de
to
3b8acc5
Compare
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
3b8acc5
to
a221d90
Compare
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
a221d90
to
3bae0bf
Compare
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
3 times, most recently
from
8921f5d
to
aca4d95
Compare
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
2 times, most recently
from
ce2c34a
to
62a8170
Compare
dli-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
62a8170
to
2d74cbc
Compare
jpr-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
2d74cbc
to
ec9181a
Compare
jpr-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
1d50f56
to
24b3b23
Compare
rop-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
24b3b23
to
7021449
Compare
rim-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
from
7021449
to
77f2863
Compare
rim-odoo
suggested changes
Dec 12, 2017
| @@ -139,6 +139,7 @@ | |||
| {'no_create_edit': True}"/> | |||
| <field name="alarm_ids" widget="many2many_tags" /> | |||
| <field name="location" /> | |||
| <field name="event_tz" /> | |||
There was a problem hiding this comment.
Hide if not recurring event, else it will be confusing
| @@ -528,7 +528,8 @@ def _prepare_holidays_meeting_values(self): | |||
| 'stop': self.date_to, | |||
| 'allday': False, | |||
| 'state': 'open', # to block that meeting date in the calendar | |||
| 'privacy': 'confidential' | |||
| 'privacy': 'confidential', | |||
| 'event_tz': self.user_id.tz, | |||
There was a problem hiding this comment.
Is it required since a holiday is not a recurring event?
There was a problem hiding this comment.
yes, we should add the employees timezone when creating the event. It's done upon validation, which is not done by the employee but by a manager. Unless we make the assumption the manager shares the same timezone it could be wrong.
jpr-odoo
force-pushed
the
master-recurrent-event-dst-dli
branch
3 times, most recently
from
2973f73
to
533bd3e
Compare
tivisse
force-pushed
the
master-recurrent-event-dst-dli
branch
from
533bd3e
to
9292227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The daylight savings time (summer/winter time) is taken into account when creating a recurrent event via calendar which causes problem in time.
e.g:
Whenever you create an event in Brussels timezone for ex. it goes either 1 hour prior or 1 hour after scheduled event time in case of daylight saving time(in March, October).